build(PnPM Proposal): faster builds and install #297 #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposal issue link
jodit-react is a relatively small but widely used project that serves as a good use case, particularly for contributors.
PnPM is also used in many packages including next.js and many more, largely for performance/efficiency reasons. Given the use cases i had (mentioned in issue) i thought jodit-react could definetely benefit.
Possibly requires a workflow update before merge?
Note I don't have visibility of workflows to publish or github actions which publish.
If its manual install and use pnpm
if its automated or via github workflows then for useful reference of what minor changes might be needed to that type of workflow see here useful link for updating publish worfklows with pnpm
Fixes #297