Merged
Conversation
- Updated the CSS for the `.card-flavor-text` class to include `font-style: italic` in various SVG files and the CSS service. - Ensured consistency in styling for flavor text elements in card designs. - Added spec coverage to catch this issue in the future
- Introduced a new Ruby script to convert SVG files to WebP format using Chrome in headless mode. - Implemented functionality for error handling, cropping, and cleanup after conversion. - The script outputs the converted WebP file and provides feedback on the conversion process.
- Introduced a new section detailing the experimental feature for converting SVG cards to WebP format, specifically for macOS users. - Included prerequisites, usage instructions, and features of the WebP conversion tool. - Highlighted caveats and future plans for cross-platform support.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug related to CSS styling for flavor text and adds an experimental WebP conversion feature for MTG cards. The changes improve the text rendering system and provide a new tool for converting SVG cards to WebP format.
- Added italic font styling for flavor text elements to distinguish them from rules text
- Introduced comprehensive test coverage for the CSS service functionality
- Added experimental WebP conversion script with macOS Chrome support
Reviewed Changes
Copilot reviewed 4 out of 21 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/mtg_card_maker/css_service.rb | Adds italic font styling to flavor text CSS class |
| spec/mtg_card_maker/css_service_spec.rb | Comprehensive test suite for CSS service methods and font styling |
| spec/mtg_card_maker/text_box_layer_spec.rb | Test for CSS class application to flavor and rules text elements |
| README.md | Documentation for new experimental WebP conversion feature and usage examples |
Comments suppressed due to low confidence (1)
README.md:327
- Missing closing backslash for line continuation. The line should end with a backslash to properly continue the command on the next line.
--color=blue \
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new features, updates to the documentation, and enhancements to the CSS styling and testing for the
mtg_card_makerproject. The most notable changes include the addition of an experimental WebP conversion feature, updates to the CSS for card elements, and comprehensive tests for the CSS service.New Features:
Documentation Updates:
generate_cardexample to include an--artoption for specifying artwork in.webpformat.CSS Enhancements:
.card-flavor-textclass to use italic font styling for better visual distinction.Testing Improvements:
MtgCardMaker::CssService, covering CSS generation, font embedding, and styling behavior.