Manual logout - #12
Open
emadpoursina wants to merge 5 commits into
Open
Conversation
Owner
|
Hey @emadpoursina, How is this going to be different from "Allow" logic? In Allow option, if the limit is reached, they will be able to log in instantly by removing all other existing sessions of their account. |
Author
|
Hi @joel-james The different is in user's option. In The third and my option user can decide to log out or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add a third option to the logout logic, so the user can decide to delete all the other session and then log out.
I think it's better than block because user can instantly login and it's better than allow because user decide by himself/herself to logout from other sessions and it's better privacy.