add isuri to types #64
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeltankam
requested changes
Oct 22, 2018
Owner
joeltankam
left a comment
joeltankam
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
Some changes needed. Also, please update documentation.
src/is/types.js
Outdated
| @@ -1,4 +1,5 @@ | |||
| const { toString } = Object.prototype; | |||
| const uriRegex = /^([a-z]+\:\/{2})(([a-zA-Z0-9]+([_ -]*[a-zA-Z0-9])*)(:[!#$%^&*\)(}{\[\]\\\|\/\~\`\;\"\'\?\>\<\+\-\.a-zA-Z0-9]*@)?)?([w]{3}\.)?([a-zA-Z0-9]+([_ -]*[a-zA-Z0-9])*\.[a-z]*)(\:[\d]*)?(\/[a-zA-Z0-9]+(\.[a-zA-Z]+)?)*((\?[a-zA-Z]+\=[a-zA-Z0-9]+)*)?((\#[a-zA-Z]+(\=[a-zA-Z0-9]+)?)*)?/ | |||
src/is/types.js
Outdated
| * @param {*} value the value to check | ||
| * @returns {Boolean} `true` if the value is a URI; otherwise, `false` | ||
| */ | ||
| export function isURI(value) { |
Owner
There was a problem hiding this comment.
Shouldn't be in this file, but rather regexp.js as mentioned in the issue description.
test/is/types.test.js
Outdated
|
|
||
| describe('isURI', () => { | ||
| const uriFull = "http://abc:[email protected]/path1/path2?param1=value1?param2=value2#frag1=fragvalue1"; | ||
| test('should return true on correct URI string', () => { |
Owner
There was a problem hiding this comment.
Please follow the same syntax as the existing tests
…nto isuriregex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.