Modernisation#11
Open
utopalex wants to merge 13 commits into
Open
Conversation
Kotlinize PlaybackService, add first draft of headless mode, allow entering filename directly, update README
janevert
reviewed
Jun 8, 2021
| } | ||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:3.1.1' | ||
| classpath 'com.android.tools.build:gradle:4.1.0' |
There was a problem hiding this comment.
I suggest to put the gradle update in a separate commit.
janevert
reviewed
Jun 8, 2021
| MainActivity.this, | ||
| permission) | ||
| == PackageManager.PERMISSION_DENIED) { | ||
| ActivityCompat |
There was a problem hiding this comment.
This really is quite ugly formatting of code. There is no reason for it.
Is your editor perhaps inserting tab instead of space?
janevert
reviewed
Jun 8, 2021
| } | ||
| } | ||
| case MY_PERMISSIONS_REQUEST_STORAGE: { | ||
| Log.d("Main", "Location permitted"); |
There was a problem hiding this comment.
Storage permitted instead of location permitted.
janevert
reviewed
Jun 8, 2021
| Settings.Secure.ALLOW_MOCK_LOCATION).equals("0") | ||
| } | ||
| } catch (e: Exception) { | ||
| Log.d(TAG, "Mock location is not enabled.") |
There was a problem hiding this comment.
I suggest to make this a Log.w. It is a quite important log!
I do expect that this is only logged once when the app starts?
janevert
reviewed
Jun 8, 2021
| } catch (e: ParseException) { | ||
| val gpsDate = LESS_LONG_DATE_FORMAT.parse(item.time) | ||
| gpsPointTime = gpsDate.time | ||
| for (i in 0..1) { |
There was a problem hiding this comment.
I suppose in kotlin there is also something like DATE_FORMATTERS.length ?
janevert
reviewed
Jun 8, 2021
| try { | ||
| val gpsDate = DATE_FORMATTERS[i].parse(item.time) | ||
| gpsPointTime = gpsDate.time | ||
| parsed = true |
There was a problem hiding this comment.
Perhaps add a break statement after this?
Fixed 'Provider "gps" unknown'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for starting mocking by intent, fixes issues with parsing certain files, support for altitude, heading and speed.