Skip to content

Change hook from post_update to wp_after_insert_post #4205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
obstschale wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Change hook from post_update to wp_after_insert_post #4205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion models/monitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public function __construct( array $options ) {
// Only monitor if permalinks enabled
if ( get_option( 'permalink_structure' ) !== false ) {
add_action( 'pre_post_update', array( $this, 'pre_post_update' ), 10, 2 );
add_action( 'post_updated', array( $this, 'post_updated' ), 11, 3 );
add_action( 'wp_after_insert_post', array( $this, 'post_after_insert' ), 11, 4 );
add_action( 'redirection_remove_existing', array( $this, 'remove_existing_redirect' ) );
add_filter( 'redirection_permalink_changed', array( $this, 'has_permalink_changed' ), 10, 3 );

Expand Down Expand Up @@ -83,6 +83,27 @@ public function can_monitor_post( ?WP_Post $post, ?WP_Post $post_before ): bool
return true;
}

/**
* Called after a post and its terms have been inserted or updated. This hook
* fires after term assignment in both the classic editor and the REST/block
* editor flows, so the new permalink is always available when we compare it
* against the one captured in `pre_post_update`.
*
* @param int $post_id
* @param WP_Post|null $post
* @param bool $update
* @param WP_Post|null $post_before
* @return void
*/
public function post_after_insert( int $post_id, ?WP_Post $post, bool $update, ?WP_Post $post_before ): void {
// A slug cannot change on insertion, so skip brand-new posts.
if ( ! $update ) {
return;
}

$this->post_updated( $post_id, $post, $post_before );
}

/**
* Called when a post has been updated - check if the slug has changed
*
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/models/test-monitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,15 +228,15 @@ public function testPostUpdatedWithNullPostExitsCleanly() {
public function testNoHooks() {
$monitor = new Red_Monitor( array( 'monitor_post' => 0, 'monitor_types' => array() ) );

$this->assertFalse( has_action( 'post_updated', array( $monitor, 'post_updated' ) ) );
$this->assertFalse( has_action( 'wp_after_insert_post', array( $monitor, 'post_after_insert' ) ) );
$this->assertFalse( has_action( 'edit_form_advanced', array( $monitor, 'insert_old_post' ) ) );
$this->assertFalse( has_action( 'edit_page_form', array( $monitor, 'insert_old_post' ) ) );
}

public function testHasHooks() {
$monitor = new Red_Monitor( $this->getActiveOptions() );

$this->assertEquals( 11, has_action( 'post_updated', array( $monitor, 'post_updated' ) ) );
$this->assertEquals( 11, has_action( 'wp_after_insert_post', array( $monitor, 'post_after_insert' ) ) );
$this->assertEquals( 10, has_action( 'pre_post_update', array( $monitor, 'pre_post_update' ) ) );
}

Expand Down