Fix missing created time in logs#4210
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores display of the “created time” for redirect and 404 log entries by ensuring the API schema accepts a created_time field and updating the relevant log table column renderers to show it.
Changes:
- Extend the
LogSchemaZod schema to include an optionalcreated_timefield so it isn’t dropped during parsing. - Update the redirect logs (
src/page/logs) and 404 logs (src/page/logs404) column renderers to displaycreated_timeunder the date when present.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/types/schemas/log.ts |
Adds created_time to LogSchema so the parsed log objects retain the time field. |
src/page/logs404/columns.tsx |
Displays created_time in the “date” column for 404 logs. |
src/page/logs/columns.tsx |
Displays created_time in the “date” column for redirect logs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 404 and redirect logs are missing the time and are just showing the date. Add the time back