Skip to content

Fix missing created time in logs#4210

Merged
johngodley merged 1 commit into
trunkfrom
fix/created-time
May 31, 2026
Merged

Fix missing created time in logs#4210
johngodley merged 1 commit into
trunkfrom
fix/created-time

Conversation

@johngodley
Copy link
Copy Markdown
Owner

The 404 and redirect logs are missing the time and are just showing the date. Add the time back

Copilot AI review requested due to automatic review settings May 31, 2026 14:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores display of the “created time” for redirect and 404 log entries by ensuring the API schema accepts a created_time field and updating the relevant log table column renderers to show it.

Changes:

  • Extend the LogSchema Zod schema to include an optional created_time field so it isn’t dropped during parsing.
  • Update the redirect logs (src/page/logs) and 404 logs (src/page/logs404) column renderers to display created_time under the date when present.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/types/schemas/log.ts Adds created_time to LogSchema so the parsed log objects retain the time field.
src/page/logs404/columns.tsx Displays created_time in the “date” column for 404 logs.
src/page/logs/columns.tsx Displays created_time in the “date” column for redirect logs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@johngodley johngodley merged commit 04ac820 into trunk May 31, 2026
9 checks passed
@johngodley johngodley deleted the fix/created-time branch May 31, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants