Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/selectools/entity_memory.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from __future__ import annotations

import json
import logging
import re
import threading
import time
Expand All @@ -17,6 +18,8 @@
from .stability import stable
from .types import Message, Role

logger = logging.getLogger(__name__)


@stable
@dataclass
Expand Down Expand Up @@ -173,6 +176,7 @@ def extract_entities(
)
return extracted
except Exception:
logger.warning("Entity extraction failed", exc_info=True)
return []

def update(self, entities: List[Entity]) -> None:
Expand Down
9 changes: 9 additions & 0 deletions tests/test_entity_memory.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,15 @@ def test_invalid_json_returns_empty(self) -> None:
result = em.extract_entities([Message(role=Role.USER, content="test")])
assert result == []

def test_provider_failure_logs_warning(self, caplog) -> None:
import logging as _logging

em = EntityMemory(provider=FailingProvider())
with caplog.at_level(_logging.WARNING, logger="selectools.entity_memory"):
result = em.extract_entities([Message(role=Role.USER, content="test")])
assert result == []
assert "Entity extraction failed" in caplog.text

def test_respects_relevance_window(self) -> None:
entities_json = json.dumps([{"name": "X", "entity_type": "concept"}])
provider = FakeExtractionProvider(entities_json)
Expand Down