Skip to content

⚡ Verify AStar visited set Contains check complexity - #155

Merged
johnstrand merged 1 commit into
masterfrom
perf/astar-contains-check-13873159358295831929
Aug 29, 2026
Merged

⚡ Verify AStar visited set Contains check complexity#155
johnstrand merged 1 commit into
masterfrom
perf/astar-contains-check-13873159358295831929

Conversation

@johnstrand

Copy link
Copy Markdown
Owner

💡 What: Added AStarBenchmarks to the benchmark suite and verified that _visited in AStar is already a HashSet, providing O(1) Contains lookups.

🎯 Why: The issue hypothesized an O(N) lookup for _visited.Contains(neighbor), but code analysis confirmed _visited is declared as HashSet _visited = [], which already performs O(1) lookups.

📊 Measured Improvement: Verified that _visited is already a HashSet with O(1) Contains lookups. Added AStarBenchmarks to benchmark pathfinding operations.


PR created automatically by Jules for task 13873159358295831929 started by @johnstrand

Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@johnstrand
johnstrand merged commit 1abd9c6 into master Aug 29, 2026
1 check passed
@johnstrand
johnstrand deleted the perf/astar-contains-check-13873159358295831929 branch August 29, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant