🧹 Refactor WeightedRandom to remove code duplication - #159
Conversation
Extract IReadOnlyList and IList handling into a zero-allocation generic helper method. Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Extracted duplicated IReadOnlyList and IList logic in WeightedRandom into a zero-allocation generic helper method.
💡 Why: Eliminates code duplication while preserving high-performance zero-allocation requirements for game loops.
✅ Verification: Added comprehensive unit tests for WeightedRandom and ran all tests with dotnet test.
✨ Result: Clean, maintainable code with zero allocations and zero duplication.
PR created automatically by Jules for task 13374333665567477212 started by @johnstrand