🧹 [code health] Refactor monolithic ANSI Formatter in Ansi.cs - #160
Conversation
…lpers Refactored the loop body of `Ansi.Format` in `Ansi.cs` into dedicated token sequence parsing methods (`ProcessSequence`, `TryProcessResetOrStyle`, `TryProcessColorSequence`) operating on `ReadOnlySpan<char>`. Added comprehensive unit tests in `AnsiTests.cs` covering styles, colors, resets, escaped brackets, and error handling. Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Refactored the monolithic
Ansi.Formatmethod by decomposing its loop body into dedicated helper methods (ProcessSequence,TryProcessResetOrStyle,TryProcessColorSequence). Added unit tests inAnsiTests.cs.💡 Why: Reduces method complexity and improves readability and maintainability without allocating heap memory or altering existing error contracts.
✅ Verification: Ran
dotnet test, passing all 446 unit tests.✨ Result: Improved modularity and readability of ANSI format processing.
PR created automatically by Jules for task 15597934433165898963 started by @johnstrand