Added methods for working on env slices. #131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes * Added methods for working on env slices. * Added tests * Load and Overload uses Read (code reuse) * Avoid using return arguments `raw return` (antipattern) * Exec does not pollute current process environment variables when invoked. This allows easy use with with os/exec package. Signed-off-by: Bartlomiej Plotka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the amazing project, hope you don't mind minor reuse and extra usability methods. 🤗
Changes
raw return(antipattern)This allows easy use with
os/execpackage.Hope this makes sense (:
Signed-off-by: Bartlomiej Plotka [email protected]