win32 only change #11
Open
+103
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than a single matrix that covers all OSes, split them up so that enumerating different ones is a little easier. This has three benefits: 1. `matrix.exclude` is easier to write in this format 2. Tools like `act` work with simple string matrix dimensions (see new comment at top of maven.yml) 3. conditional execution on file name pattens are easier to implement (see subsequent PR on this topic) Part of eclipse-platform#2714
Many of the PRs on SWT are OS specific, this change only runs the build on OSes if there are changes that can affect that OS. This is going to be more important with eclipse-platform#2714 because potentially a number of new jobs will be run per PR and avoiding some of the extra time waiting will be a benefit to all. The minor negative of skipping tests conditionally is that the **Test Results** summary comment will report less runs that base commit. Part of eclipse-platform#2714
Test Results 34 files - 84 34 suites - 84 5m 41s ⏱️ - 11m 9s Results for commit 56340b7. ± Comparison against base commit 73e542b. This pull request removes 44 tests.This pull request skips 50 tests.♻️ This comment has been updated with latest results. |
jonahgraham
force-pushed
the
win32-only
branch
from
e964cea to
56340b7
Compare
jonahgraham
force-pushed
the
master
branch
3 times, most recently
from
e946e54 to
6cf80bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.