custom cofig rules DYNAMODB_TABLE_ENCRYPTED_KMS and SQS_ENCRYPTED_KMS #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeep7568
changed the title
jongogogo
requested changes
Mar 10, 2020
python/DYNAMODB_TABLE_ENCRYPTED_KMS/DYNAMODB_TABLE_ENCRYPTED_KMS.py
Outdated
Show resolved
Hide resolved
python/DYNAMODB_TABLE_ENCRYPTED_KMS/DYNAMODB_TABLE_ENCRYPTED_KMS.py
Outdated
Show resolved
Hide resolved
python/DYNAMODB_TABLE_ENCRYPTED_KMS/DYNAMODB_TABLE_ENCRYPTED_KMS.py
Outdated
Show resolved
Hide resolved
python/DYNAMODB_TABLE_ENCRYPTED_KMS/DYNAMODB_TABLE_ENCRYPTED_KMS.py
Outdated
Show resolved
Hide resolved
python/DYNAMODB_TABLE_ENCRYPTED_KMS/DYNAMODB_TABLE_ENCRYPTED_KMS.py
Outdated
Show resolved
Hide resolved
python/DYNAMODB_TABLE_ENCRYPTED_KMS/DYNAMODB_TABLE_ENCRYPTED_KMS.py
Outdated
Show resolved
Hide resolved
python/DYNAMODB_TABLE_ENCRYPTED_KMS/DYNAMODB_TABLE_ENCRYPTED_KMS_test.py
Outdated
Show resolved
Hide resolved
python/DYNAMODB_TABLE_ENCRYPTED_KMS/DYNAMODB_TABLE_ENCRYPTED_KMS_test.py
Outdated
Show resolved
Hide resolved
python/DYNAMODB_TABLE_ENCRYPTED_KMS/DYNAMODB_TABLE_ENCRYPTED_KMS_test.py
Outdated
Show resolved
Hide resolved
python/DYNAMODB_TABLE_ENCRYPTED_KMS/DYNAMODB_TABLE_ENCRYPTED_KMS_test.py
Outdated
Show resolved
Hide resolved
sajidjkd
reviewed
Apr 10, 2020
python/DYNAMODB_TABLE_ENCRYPTED_KMS/DYNAMODB_TABLE_ENCRYPTED_KMS.py
Outdated
Show resolved
Hide resolved
python/DYNAMODB_TABLE_ENCRYPTED_KMS/DYNAMODB_TABLE_ENCRYPTED_KMS.py
Outdated
Show resolved
Hide resolved
python/DYNAMODB_TABLE_ENCRYPTED_KMS/DYNAMODB_TABLE_ENCRYPTED_KMS.py
Outdated
Show resolved
Hide resolved
python/DYNAMODB_TABLE_ENCRYPTED_KMS/DYNAMODB_TABLE_ENCRYPTED_KMS.py
Outdated
Show resolved
Hide resolved
python/DYNAMODB_TABLE_ENCRYPTED_KMS/DYNAMODB_TABLE_ENCRYPTED_KMS_test.py
Outdated
Show resolved
Hide resolved
python/DYNAMODB_TABLE_ENCRYPTED_KMS/DYNAMODB_TABLE_ENCRYPTED_KMS_test.py
Outdated
Show resolved
Hide resolved
sandeep7568
changed the title
sajidjkd
reviewed
Apr 14, 2020
| Scenario: 7 | ||
| Given: Amazon DynamoDB table is active | ||
| And: KmsKeyArns Rule Parameter provided | ||
| And: Amazon DynamoDB table is not encrypted with with provided KmsKeyArns Rule Parameter |
| Then: Return NON_COMPLIANT | ||
| Scenario: 6 | ||
| Given: Amazon DynamoDB table is active | ||
| And: KmsKeyArns Rule Parameter provided |
| Scenario: 6 | ||
| Given: Amazon DynamoDB table is active | ||
| And: KmsKeyArns Rule Parameter provided | ||
| And: Amazon DynamoDB table is encrypted with provided KmsKeyArns Rule Parameter |
| Then: Return COMPLIANT | ||
| Scenario: 7 | ||
| Given: Amazon DynamoDB table is active | ||
| And: KmsKeyArns Rule Parameter provided |
| if kms_key: | ||
| if not kms_arn_list or kms_key in kms_arn_list: | ||
| return [Evaluation(ComplianceType.COMPLIANT)] | ||
| return [Evaluation(ComplianceType.NON_COMPLIANT, annotation="AWS KMS key '{}' used to encrypt the Amazon SQS Queue is not in rule_paramter 'KmsKeyArns'".format(kms_key))] |
There was a problem hiding this comment.
Annotation length has limit make sure it should not exceed 255 characters as kms_key is dynamic value
| And: Any key in "KmsKeyArns" is invalid | ||
| Then: Return ERROR | ||
| Scenario: 2 | ||
| Given: Rules parameter is provided |
There was a problem hiding this comment.
Is returning Success valid scenario ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm these files are made available under CC0 1.0 Universal (https://creativecommons.org/publicdomain/zero/1.0/legalcode)
Issue #, if available:
Description of changes:
custom cofig rule to check the dynamodb table is encrypted with KMS