forked from awslabs/aws-config-rules
-
Notifications
You must be signed in to change notification settings - Fork 10
Custom config rule to check that AMI target EBS encrypted #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kiranmoka
wants to merge
3
commits into
jongogogo:master
Choose a base branch
from
Kiranmoka:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
# Copyright 2017-2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"). You may | ||
# not use this file except in compliance with the License. A copy of the License is located at | ||
# | ||
# http://aws.amazon.com/apache2.0/ | ||
# | ||
# or in the "license" file accompanying this file. This file is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for | ||
# the specific language governing permissions and limitations under the License. | ||
''' | ||
##################################### | ||
## Gherkin ## | ||
##################################### | ||
Rule Name: | ||
AMI_EBS_ENCRYPTED | ||
|
||
Description: | ||
Check EBS-backed AMI is encrypted. | ||
|
||
Rationale: | ||
Encrypting on EBS ensure that no data is written on disk in clear text. | ||
|
||
Indicative Severity: | ||
Medium | ||
|
||
Trigger: | ||
Periodic | ||
|
||
Reports on: | ||
AWS::::Account | ||
|
||
Scenarios: | ||
Scenario: 1 | ||
Given: AMI target EBS is encrypted | ||
Then: Return COMPLIANT | ||
Scenario: 2 | ||
Given: AMI target EBS is not encrypted | ||
Then: Return NON_COMPLIANT | ||
''' | ||
|
||
from rdklib import Evaluator, Evaluation, ConfigRule, ComplianceType | ||
|
||
DEFAULT_RESOURCE_TYPE = 'AWS::::Account' | ||
|
||
class AMI_EBS_ENCRYPTED(ConfigRule): | ||
|
||
def evaluate_periodic(self, event, client_factory, valid_rule_parameters): | ||
ec2_client = client_factory.build_client('ec2') | ||
evaluations = [] | ||
amis = ec2_client.describe_images(Owners=["self"]) | ||
for ami in amis.get('Images'): | ||
block_devices = ami.get('BlockDeviceMappings') | ||
for block_device in block_devices: | ||
ebs = block_device.get('Ebs') | ||
if ebs and ebs['Encrypted']: | ||
evaluations.append(Evaluation(ComplianceType.COMPLIANT, ami.get('ImageId'), DEFAULT_RESOURCE_TYPE)) | ||
else: | ||
evaluations.append(Evaluation(ComplianceType.NON_COMPLIANT, ami.get('ImageId'), DEFAULT_RESOURCE_TYPE, | ||
annotation="AMI target EBS is not encrypted")) | ||
return evaluations | ||
|
||
def lambda_handler(event, context): | ||
my_rule = AMI_EBS_ENCRYPTED() | ||
evaluator = Evaluator(my_rule) | ||
return evaluator.handle(event, context) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
# Copyright 2017-2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"). You may | ||
# not use this file except in compliance with the License. A copy of the License is located at | ||
# | ||
# http://aws.amazon.com/apache2.0/ | ||
# | ||
# or in the "license" file accompanying this file. This file is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for | ||
# the specific language governing permissions and limitations under the License. | ||
|
||
import unittest | ||
from mock import patch, MagicMock | ||
from rdklib import Evaluation, ComplianceType | ||
import rdklibtest | ||
|
||
RESOURCE_TYPE = 'AWS::::Account' | ||
|
||
MODULE = __import__('AMI_EBS_ENCRYPTED') | ||
RULE = MODULE.AMI_EBS_ENCRYPTED() | ||
|
||
CLIENT_FACTORY = MagicMock() | ||
EC2_CLIENT_MOCK = MagicMock() | ||
|
||
def mock_get_client(client_name, *args, **kwargs): | ||
if client_name == 'ec2': | ||
return EC2_CLIENT_MOCK | ||
raise Exception("Attempting to create an unknown client") | ||
|
||
@patch.object(CLIENT_FACTORY, 'build_client', MagicMock(side_effect=mock_get_client)) | ||
class ComplianceTest(unittest.TestCase): | ||
|
||
non_encrypted_ami_ebs = { | ||
"Images": [{ | ||
"ImageId": "ami-0112c52e7ca89ee2e", | ||
"BlockDeviceMappings": [{ | ||
"Ebs": { | ||
"Encrypted": False | ||
} | ||
}] | ||
}] | ||
} | ||
encrypted_ami_ebs = { | ||
"Images": [{ | ||
"ImageId": "ami-08d7261cad6c06507", | ||
"BlockDeviceMappings": [{ | ||
"Ebs": { | ||
"Encrypted": True | ||
} | ||
}] | ||
}] | ||
} | ||
|
||
def test_scenario1_amitargetebsencrypted_returnscompliant(self): | ||
EC2_CLIENT_MOCK.describe_images.return_value = self.encrypted_ami_ebs | ||
response = RULE.evaluate_periodic("", CLIENT_FACTORY, "") | ||
resp_expected = [ | ||
Evaluation(ComplianceType.COMPLIANT, "ami-08d7261cad6c06507", RESOURCE_TYPE) | ||
] | ||
rdklibtest.assert_successful_evaluation(self, response, resp_expected) | ||
|
||
def test_scenario2_amitargetebsnotencrypted_returnsnoncompliant(self): | ||
EC2_CLIENT_MOCK.describe_images.return_value = self.non_encrypted_ami_ebs | ||
response = RULE.evaluate_periodic("", CLIENT_FACTORY, "") | ||
resp_expected = [ | ||
Evaluation(ComplianceType.NON_COMPLIANT, "ami-0112c52e7ca89ee2e", RESOURCE_TYPE, | ||
annotation="AMI target EBS is not encrypted") | ||
] | ||
rdklibtest.assert_successful_evaluation(self, response, resp_expected, 1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
"Version": "1.0", | ||
"Parameters": { | ||
"RuleName": "AMI_EBS_ENCRYPTED", | ||
"SourceRuntime": "python3.6-lib", | ||
"SourcePeriodic": "One_Hour", | ||
"CodeKey": "AMI_EBS_ENCRYPTED.zip", | ||
"InputParameters": "{}", | ||
"OptionalParameters": "{}", | ||
"SourceEvents": "AWS::EC2::Volume" | ||
}, | ||
"Tags": "[]" | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.