forked from awslabs/aws-config-rules
-
Notifications
You must be signed in to change notification settings - Fork 10
adding config rule - SecurityHub Enabled #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mshri14
wants to merge
3
commits into
jongogogo:master
Choose a base branch
from
mshri14:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
# Copyright 2017-2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"). You may | ||
# not use this file except in compliance with the License. A copy of the License is located at | ||
# | ||
# http://aws.amazon.com/apache2.0/ | ||
# | ||
# or in the "license" file accompanying this file. This file is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for | ||
# the specific language governing permissions and limitations under the License. | ||
|
||
''' | ||
##################################### | ||
## Gherkin ## | ||
##################################### | ||
|
||
Rule Name: | ||
SECURITYHUB_ENABLED | ||
|
||
Description: | ||
Checks whether SecurityHub is enabled. The rule is NON_COMPLIANT if SecurityHub is not enabled. | ||
|
||
Rationale: | ||
AWS Security Hub gives you a comprehensive view of your high-priority security alerts, | ||
and compliance status across AWS accounts. | ||
|
||
Indicative Severity: | ||
Medium | ||
|
||
Trigger: | ||
Periodic | ||
|
||
Reports on: | ||
AWS::::Account | ||
|
||
Rule Parameters: | ||
None | ||
|
||
Scenarios: | ||
Scenario: 1 | ||
Given: SecurityHub is enabled. | ||
Then: Return COMPLIANT | ||
|
||
Scenario: 2 | ||
Given: SecurityHub is not enabled. | ||
Then: Return NON_COMPLIANT with Annotation | ||
''' | ||
|
||
from rdklib import Evaluator, Evaluation, ConfigRule, ComplianceType | ||
|
||
RESOURCE_TYPE = 'AWS::::Account' | ||
|
||
class SECURITYHUB_ENABLED(ConfigRule): | ||
def evaluate_periodic(self, event, client_factory, valid_rule_parameters): | ||
client = client_factory.build_client('securityhub') | ||
is_securityhub_enabled = True | ||
try: | ||
response = client.describe_hub() | ||
except: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not catch all |
||
is_securityhub_enabled = False | ||
if is_securityhub_enabled: | ||
print('HubArn:' + response['HubArn']) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove print statement |
||
print('SecurityHub Enabled.') | ||
return [Evaluation(ComplianceType.COMPLIANT, event['accountId'], RESOURCE_TYPE)] | ||
print('HubArn: None') | ||
print('SecurityHub NOT Enabled.') | ||
return [Evaluation(ComplianceType.NON_COMPLIANT, event['accountId'], RESOURCE_TYPE, | ||
'AWS SecurityHub is not enabled.')] | ||
|
||
def lambda_handler(event, context): | ||
my_rule = SECURITYHUB_ENABLED() | ||
evaluator = Evaluator(my_rule) | ||
return evaluator.handle(event, context) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
# Copyright 2017-2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"). You may | ||
# not use this file except in compliance with the License. A copy of the License is located at | ||
# | ||
# http://aws.amazon.com/apache2.0/ | ||
# | ||
# or in the "license" file accompanying this file. This file is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for | ||
# the specific language governing permissions and limitations under the License. | ||
|
||
import unittest | ||
from mock import patch, MagicMock | ||
from rdklib import Evaluation, ComplianceType | ||
import rdklibtest | ||
|
||
############## | ||
# Parameters # | ||
############## | ||
|
||
# Define the default resource to report to Config Rules | ||
RESOURCE_TYPE = 'AWS::::Account' | ||
|
||
############# | ||
# Main Code # | ||
############# | ||
|
||
MODULE = __import__('SECURITYHUB_ENABLED') | ||
RULE = MODULE.SECURITYHUB_ENABLED() | ||
|
||
CLIENT_FACTORY = MagicMock() | ||
|
||
SECURITYHUB_CLIENT_MOCK = MagicMock() | ||
|
||
MOCK_SECURITYHUB_ENABLED = { | ||
"HubArn": "arn:aws:securityhub:ap-southeast-1:632747342146:hub/default", | ||
"SubscribedAt": "2020-03-03T04:54:41.610Z" | ||
} | ||
|
||
MOCK_EVENT = { | ||
"accountId": "632747342146" | ||
} | ||
|
||
def mock_get_client(client_name, *args, **kwargs): | ||
if client_name == 'securityhub': | ||
return SECURITYHUB_CLIENT_MOCK | ||
raise Exception("Attempting to create an unknown client") | ||
|
||
def my_side_effect(): | ||
raise Exception("An error occurred (InvalidAccessException) when calling the DescribeHub operation: AccountId: 632747342146 is not enabled for securityhub. Currentstate: false") | ||
|
||
@patch.object(CLIENT_FACTORY, 'build_client', MagicMock(side_effect=mock_get_client)) | ||
class ComplianceTest(unittest.TestCase): | ||
|
||
def test_evaluate_periodic_1_compliant(self): | ||
SECURITYHUB_CLIENT_MOCK.describe_hub.return_value = MOCK_SECURITYHUB_ENABLED | ||
response = RULE.evaluate_periodic(MOCK_EVENT, CLIENT_FACTORY, {}) | ||
resp_expected = [ | ||
Evaluation(ComplianceType.COMPLIANT, '632747342146', RESOURCE_TYPE) | ||
] | ||
rdklibtest.assert_successful_evaluation(self, response, resp_expected, 1) | ||
|
||
def test_evaluate_periodic_2_non_compliant(self): | ||
SECURITYHUB_CLIENT_MOCK.describe_hub.side_effect = my_side_effect | ||
response = RULE.evaluate_periodic(MOCK_EVENT, CLIENT_FACTORY, {}) | ||
resp_expected = [ | ||
Evaluation(ComplianceType.NON_COMPLIANT, '632747342146', RESOURCE_TYPE, 'AWS SecurityHub is not enabled.') | ||
] | ||
rdklibtest.assert_successful_evaluation(self, response, resp_expected, 1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"Version": "1.0", | ||
"Parameters": { | ||
"RuleName": "SECURITYHUB_ENABLED", | ||
"SourceRuntime": "python3.6-lib", | ||
"CodeKey": "SECURITYHUB_ENABLED.zip", | ||
"InputParameters": "{}", | ||
"OptionalParameters": "{}", | ||
"SourcePeriodic": "One_Hour" | ||
}, | ||
"Tags": "[]" | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no break line