Skip to content

Conversation

@mordak
Copy link
Contributor

@mordak mordak commented Apr 24, 2021

Follow up on #179.

We seem to have handled this with the recent work on UnsolicitedResponse, so I just added a test to make sure we continue to handle this.


This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 25, 2021

Codecov Report

Merging #196 (e79c0ae) into master (18ebf56) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   77.75%   78.02%   +0.26%     
==========================================
  Files          15       15              
  Lines        1722     1734      +12     
==========================================
+ Hits         1339     1353      +14     
+ Misses        383      381       -2     
Impacted Files Coverage Δ
src/parse.rs 88.10% <100.00%> (+0.41%) ⬆️
src/types/unsolicited_response.rs 40.00% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18ebf56...e79c0ae. Read the comment docs.

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks!

@jonhoo jonhoo merged commit 1db492e into jonhoo:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants