More methods in Nginx.pm

[sockmonk]

Basically I tried to copy as much of the Apache.pm functionality into Nginx.pm as I could figure out. Not really well tested yet, so there are probably some lurking bugs, but I wanted to go ahead and get this to you now to look at. Thanks again.

[jonswar]

Thanks!

log_dir is optional, so _build_pid_file should see if there is a log_dir, call super otherwise

Otherwise, it looks good. If you add some tests I'd be happy to integrate it!

Jon

On Aug 15, 2012, at 5:57 AM, Wes Sheldahl wrote:

Basically I tried to copy as much of the Apache.pm functionality into Nginx.pm as I could figure out. Not really well tested yet, so there are probably some lurking bugs, but I wanted to go ahead and get this to you now to look at. Thanks again.

You can merge this Pull Request by running:

git pull https://github.com/sockmonk/perl-server-control master
Or view, comment on, or merge it at:

#1

Commit Summary

implement more of Apache.pm's functionality in Nginx.pm
File Changes

M lib/Server/Control/Nginx.pm (163)
M t/00-load.t (4)
Patch Links

https://github.com/jonswar/perl-server-control/pull/1.patch
https://github.com/jonswar/perl-server-control/pull/1.diff
—
Reply to this email directly or view it on GitHub.

[sockmonk]

Thanks, Jon. I'll make that change and try to add some tests.

This is my first time working with dzil; to get it to build, I had to
comment out one line in dist.ini, otherwise it complained about a missing
author dependency, but I couldn't find this plugin on CPAN:

; [PkgVersionIfModuleWithPod]

Is that something you have locally, or is it supplied as part of something
else I should install?

Wes

On Thu, Aug 16, 2012 at 8:15 AM, Jonathan Swartz
[email protected]:

Thanks!

log_dir is optional, so _build_pid_file should see if there is a log_dir,
call super otherwise

Otherwise, it looks good. If you add some tests I'd be happy to integrate
it!

Jon

On Aug 15, 2012, at 5:57 AM, Wes Sheldahl wrote:

Basically I tried to copy as much of the Apache.pm functionality into
Nginx.pm as I could figure out. Not really well tested yet, so there are
probably some lurking bugs, but I wanted to go ahead and get this to you
now to look at. Thanks again.

You can merge this Pull Request by running:

git pull https://github.com/sockmonk/perl-server-control master
Or view, comment on, or merge it at:

#1

Commit Summary

implement more of Apache.pm's functionality in Nginx.pm
File Changes

M lib/Server/Control/Nginx.pm (163)
M t/00-load.t (4)
Patch Links

https://github.com/jonswar/perl-server-control/pull/1.patch
https://github.com/jonswar/perl-server-control/pull/1.diff
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-7783674.

Wes Sheldahl
[email protected]

[jonswar]

Yeah, this is something I have locally, I have to put it on cpan...

On Aug 16, 2012, at 5:35 AM, Wes Sheldahl wrote:

Thanks, Jon. I'll make that change and try to add some tests.

This is my first time working with dzil; to get it to build, I had to
comment out one line in dist.ini, otherwise it complained about a missing
author dependency, but I couldn't find this plugin on CPAN:

; [PkgVersionIfModuleWithPod]

Is that something you have locally, or is it supplied as part of something
else I should install?

Wes

On Thu, Aug 16, 2012 at 8:15 AM, Jonathan Swartz
[email protected]:

Thanks!

log_dir is optional, so _build_pid_file should see if there is a log_dir,
call super otherwise

Otherwise, it looks good. If you add some tests I'd be happy to integrate
it!

Jon

On Aug 15, 2012, at 5:57 AM, Wes Sheldahl wrote:

Basically I tried to copy as much of the Apache.pm functionality into
Nginx.pm as I could figure out. Not really well tested yet, so there are
probably some lurking bugs, but I wanted to go ahead and get this to you
now to look at. Thanks again.

You can merge this Pull Request by running:

git pull https://github.com/sockmonk/perl-server-control master
Or view, comment on, or merge it at:

#1

Commit Summary

implement more of Apache.pm's functionality in Nginx.pm
File Changes

M lib/Server/Control/Nginx.pm (163)
M t/00-load.t (4)
Patch Links

https://github.com/jonswar/perl-server-control/pull/1.patch
https://github.com/jonswar/perl-server-control/pull/1.diff
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-7783674.

Wes Sheldahl
[email protected]
—
Reply to this email directly or view it on GitHub.

[jonswar]

This is available now…

https://metacpan.org/module/Dist::Zilla::Plugin::PkgVersionIfModuleWithPod

On Aug 16, 2012, at 5:35 AM, Wes Sheldahl wrote:

Thanks, Jon. I'll make that change and try to add some tests.

This is my first time working with dzil; to get it to build, I had to
comment out one line in dist.ini, otherwise it complained about a missing
author dependency, but I couldn't find this plugin on CPAN:

; [PkgVersionIfModuleWithPod]

Is that something you have locally, or is it supplied as part of something
else I should install?

Wes

On Thu, Aug 16, 2012 at 8:15 AM, Jonathan Swartz
[email protected]:

Thanks!

log_dir is optional, so _build_pid_file should see if there is a log_dir,
call super otherwise

Otherwise, it looks good. If you add some tests I'd be happy to integrate
it!

Jon

On Aug 15, 2012, at 5:57 AM, Wes Sheldahl wrote:

Basically I tried to copy as much of the Apache.pm functionality into
Nginx.pm as I could figure out. Not really well tested yet, so there are
probably some lurking bugs, but I wanted to go ahead and get this to you
now to look at. Thanks again.

You can merge this Pull Request by running:

git pull https://github.com/sockmonk/perl-server-control master
Or view, comment on, or merge it at:

#1

Commit Summary

implement more of Apache.pm's functionality in Nginx.pm
File Changes

M lib/Server/Control/Nginx.pm (163)
M t/00-load.t (4)
Patch Links

https://github.com/jonswar/perl-server-control/pull/1.patch
https://github.com/jonswar/perl-server-control/pull/1.diff
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-7783674.

Wes Sheldahl
[email protected]
—
Reply to this email directly or view it on GitHub.