Fixed wild card name matching

[qnt-dmitry]

I found the problem with wildcards and fixed it. Please merge it to the main stream.

[coveralls]

Coverage decreased (-0.2%) to 90.377% when pulling 17f4513 on quantnet-golovin:master into 19069f5 on joohoi:master.

[echarlie]

Based on some quick testing (since I'd like this functionality, too), this only works for one level of wildcarded labels. e.g. *.my.host.tld. AAAA 2600::, I will get a response for label.my.host.tld., however will not get a response for another.label.my.host.tld.

I made a half-hearted attempt to solve this with this patch to your pr:

diff --cc dns.go
index 1a7e0e0,dcfda8d..0000000
--- a/dns.go
+++ b/dns.go
@@@ -130,8 -107,26 +130,33 @@@ func (d *DNSServer) readQuery(m *dns.Ms
                        m.Ns = append(m.Ns, d.SOA)
                }
        }
 -
  }
  
+ func (d *DNSServer) getRecordByDomainName(domainName string) (Records, bool) {
+       lowerName := strings.ToLower(domainName)
+       domain, ok := d.Domains[lowerName]
+       if ok {
+               return domain, ok
+       } else {
 -              split := strings.SplitAfterN(lowerName, ".", 2)
 -              split[0] = "*"
 -              wildName := strings.Join(split, ".")
 -              domain, ok := d.Domains[wildName]
 -              for i := 0; i < len(domain.Records); i++ {
++              split := strings.Split(lowerName, ".")
++              for j := 0; j < len(split); j++ {
++                      split[0] = "*"
++                      wildName := strings.Join(split, ".")
++                      domain, ok := d.Domains[wildName]
++                      for i := 0; i < len(domain.Records); i++ {
+                       domain.Records[i].Header().Name = lowerName
++                      }
++                      if ok {
++                              return domain, ok
++                      } else {
++                              newsplit := append(split[:0], split[1:]...)
++                              split = newsplit
++                      }
+               }
                return domain, ok
+       }
+ }
+ 
  func (d *DNSServer) getRecord(q dns.Question) ([]dns.RR, error) {
        var rr []dns.RR
        var cnames []dns.RR

[qnt-dmitry]

@echarlie I added your changes.

[ckidow]

Looking Forward for a merge into master :-)

[tjhiggins]

+1

[kpd200081]

How about adding tests for this?

[joohoi]

Hi, sorry it took a while to get around to reviewing this. The PR looks good, but I'd really like to see test cases included.

[phoerious]

Giving this a small bump. Anyone working on tests?