Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check errors before overwriting them. #199

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check errors before overwriting them. #199

wants to merge 2 commits into from

Conversation

russmack
Copy link

Currently, returned errors are being ignored and overwritten. This PR handles those errors.

@coveralls
Copy link

coveralls commented Nov 23, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 89.895% when pulling cf5453e on russmack:err-checks into 9f7a158 on joohoi:master.

@ghost
Copy link

ghost commented Dec 11, 2019

Hello,

What is the status of this PR?

@joohoi
Copy link
Owner

joohoi commented Jan 8, 2020

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russmack @coveralls @joohoi