Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell check #223

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Spell check #223

wants to merge 4 commits into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Apr 7, 2020

This addresses #91

@coveralls
Copy link

coveralls commented Apr 7, 2020

Coverage Status

Coverage remained the same at 73.118% when pulling 5a773de on jsoref:spell-check into 68bb6ab on joohoi:master.

@joohoi
Copy link
Owner

joohoi commented Jan 11, 2021

Thanks for the PR @jsoref , sorry it took so long to get around it. Is this still valid, and should it work as it is or does it need some additional configuration from my end?

@jsoref
Copy link
Contributor Author

jsoref commented Jan 11, 2021

It's a few versions out of date (I released a 0.0.17) and I have a couple of insights to reduce the size of the expect list. But otherwise, yeah.

Lemme see if I can update this tonight/tomorrow.

It looks like 0.0.18 might come in the vaguely soon sense with a feature I've been planning for a long time, but don't wait for that.

@joohoi
Copy link
Owner

joohoi commented Jan 11, 2021

Ok, thanks!

@jsoref
Copy link
Contributor Author

jsoref commented Jan 11, 2021

This should be good.

With this version, you get messages like: check-spelling-sandbox@61525b2#commitcomment-45854978 -- the content of that command can be used to update the expect file fairly automatically (you can also update it manually, the file isn't particularly interesting).

I have a prototype of 0.0.18 where you can ask the bot to add a commit that applies the changes instead. But I'm want to rework it so that there's less duplicated content in the comment (right now the comment has the misspelled words twice, which is vaguely silly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants