-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spell check #223
base: master
Are you sure you want to change the base?
Spell check #223
Conversation
Thanks for the PR @jsoref , sorry it took so long to get around it. Is this still valid, and should it work as it is or does it need some additional configuration from my end? |
It's a few versions out of date (I released a 0.0.17) and I have a couple of insights to reduce the size of the expect list. But otherwise, yeah. Lemme see if I can update this tonight/tomorrow. It looks like 0.0.18 might come in the vaguely soon sense with a feature I've been planning for a long time, but don't wait for that. |
Ok, thanks! |
This should be good. With this version, you get messages like: check-spelling-sandbox@61525b2#commitcomment-45854978 -- the content of that command can be used to update the expect file fairly automatically (you can also update it manually, the file isn't particularly interesting). I have a prototype of 0.0.18 where you can ask the bot to add a commit that applies the changes instead. But I'm want to rework it so that there's less duplicated content in the comment (right now the comment has the misspelled words twice, which is vaguely silly). |
This addresses #91