Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tests to gts on utilities,notifications,forms,buttons,status,collections #343

Merged
merged 1 commit into from
Feb 10, 2025
Merged

chore: update tests to gts on utilities,notifications,forms,buttons,status,collections #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 48 additions & 27 deletions ...n/components/buttons/button-group-test.ts → .../components/buttons/button-group-test.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
import { render } from '@ember/test-helpers';
import hbs from 'htmlbars-inline-precompile';
import { registerCustomStyles } from '@frontile/theme';
import { tv } from 'tailwind-variants';
import { ButtonGroup } from '@frontile/buttons';
import { cell } from 'ember-resources';
import { settled } from '@ember/test-helpers';

module(
'Integration | Component | ButtonGroup | @frontile/buttons',
Expand Down Expand Up @@ -61,10 +63,12 @@ module(

test('it renders', async function (assert) {
await render(
hbs`<ButtonGroup data-test-id="group" as |g|>
<g.Button data-test-id="button">Button</g.Button>
<g.ToggleButton data-test-id="toggle">Toggle</g.ToggleButton>
</ButtonGroup>`
<template>
<ButtonGroup data-test-id="group" as |g|>
<g.Button data-test-id="button">Button</g.Button>
<g.ToggleButton data-test-id="toggle">Toggle</g.ToggleButton>
</ButtonGroup>
</template>
);

assert.dom('[data-test-id="group"]').exists();
Expand All @@ -75,12 +79,13 @@ module(
module('Style classes', () => {
module('@appearance', () => {
test('it adds class for default appearance', async function (assert) {
this.set('appearance', '');
await render(
hbs`<ButtonGroup data-test-id="group" @appearance={{this.appearance}} as |g|>
<g.Button data-test-id="button">Button</g.Button>
<g.ToggleButton data-test-id="toggle">Toggle</g.ToggleButton>
</ButtonGroup>`
<template>
<ButtonGroup data-test-id="group" as |g|>
<g.Button data-test-id="button">Button</g.Button>
<g.ToggleButton data-test-id="toggle">Toggle</g.ToggleButton>
</ButtonGroup>
</template>
);

assert
Expand All @@ -92,12 +97,18 @@ module(
});

test('it adds class for outlined appearance', async function (assert) {
this.set('appearance', 'outlined');
const appearance = cell<'outlined'>('outlined');
await render(
hbs`<ButtonGroup data-test-id="group" @appearance={{this.appearance}} as |g|>
<g.Button data-test-id="button">Button</g.Button>
<g.ToggleButton data-test-id="toggle">Toggle</g.ToggleButton>
</ButtonGroup>`
<template>
<ButtonGroup
data-test-id="group"
@appearance={{appearance.current}}
as |g|
>
<g.Button data-test-id="button">Button</g.Button>
<g.ToggleButton data-test-id="toggle">Toggle</g.ToggleButton>
</ButtonGroup>
</template>
);

assert.dom('[data-test-id="button"]').doesNotHaveClass('btn');
Expand All @@ -109,35 +120,45 @@ module(

module('@intent', () => {
test('it adds class for the an intent', async function (assert) {
this.set('intent', 'primary');
const intent = cell<'primary' | 'danger'>('primary');
await render(
hbs`<ButtonGroup data-test-id="group" @intent={{this.intent}} as |g|>
<g.Button data-test-id="button">Button</g.Button>
<g.ToggleButton data-test-id="toggle">Toggle</g.ToggleButton>
</ButtonGroup>`
<template>
<ButtonGroup
data-test-id="group"
@intent={{intent.current}}
as |g|
>
<g.Button data-test-id="button">Button</g.Button>
<g.ToggleButton data-test-id="toggle">Toggle</g.ToggleButton>
</ButtonGroup>
</template>
);
assert.dom('[data-test-id="button"]').hasClass('intent-primary');
assert.dom('[data-test-id="toggle"]').hasClass('intent-primary');

this.set('intent', 'danger');
intent.current = 'danger';
await settled();
assert.dom('[data-test-id="button"]').hasClass('intent-danger');
assert.dom('[data-test-id="toggle"]').hasClass('intent-danger');
});
});

module('@size', () => {
test('it adds class for the an intent', async function (assert) {
this.set('size', 'sm');
const size = cell<'sm' | 'lg'>('sm');
await render(
hbs`<ButtonGroup data-test-id="group" @size={{this.size}} as |g|>
<g.Button data-test-id="button">Button</g.Button>
<g.ToggleButton data-test-id="toggle">Toggle</g.ToggleButton>
</ButtonGroup>`
<template>
<ButtonGroup data-test-id="group" @size={{size.current}} as |g|>
<g.Button data-test-id="button">Button</g.Button>
<g.ToggleButton data-test-id="toggle">Toggle</g.ToggleButton>
</ButtonGroup>
</template>
);
assert.dom('[data-test-id="button"]').hasClass('btn-sm');
assert.dom('[data-test-id="toggle"]').hasClass('toggle-button-sm');

this.set('size', 'lg');
size.current = 'lg';
await settled();
assert.dom('[data-test-id="button"]').hasClass('btn-lg');
assert.dom('[data-test-id="toggle"]').hasClass('toggle-button-lg');
});
Expand Down
48 changes: 36 additions & 12 deletions ...ration/components/buttons/buttons-test.ts → ...ation/components/buttons/buttons-test.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
import { render } from '@ember/test-helpers';
import hbs from 'htmlbars-inline-precompile';
import { registerCustomStyles } from '@frontile/theme';
import { tv } from 'tailwind-variants';
import { Button } from '@frontile/buttons';

registerCustomStyles({
button: tv({
Expand Down Expand Up @@ -44,15 +44,21 @@ module(
setupRenderingTest(hooks);

test('it renders', async function (assert) {
await render(hbs`<Button data-test-id="button">My Button</Button>`);
await render(
<template>
<Button data-test-id="button">My Button</Button>
</template>
);

assert.dom('[data-test-id="button"]').hasText('My Button');
assert.dom('[data-test-id="button"]').hasAttribute('type', 'button');
});

test('it accepts @type argument', async function (assert) {
await render(
hbs`<Button @type="submit" data-test-id="button">My Button</Button>`
<template>
<Button @type="submit" data-test-id="button">My Button</Button>
</template>
);

assert.dom('[data-test-id="button"]').hasAttribute('type', 'submit');
Expand All @@ -61,7 +67,11 @@ module(
module('Style classes', () => {
module('@appearance', () => {
test('it adds class for default appearance', async function (assert) {
await render(hbs`<Button data-test-id="button">My Button</Button>`);
await render(
<template>
<Button data-test-id="button">My Button</Button>
</template>
);

assert
.dom('[data-test-id="button"]')
Expand All @@ -73,7 +83,9 @@ module(

test('it adds class for outlined appearance', async function (assert) {
await render(
hbs`<Button @appearance="outlined" data-test-id="button">My Button</Button>`
<template>
<Button @appearance="outlined" data-test-id="button">My Button</Button>
</template>
);

assert.dom('[data-test-id="button"]').doesNotHaveClass('btn');
Expand All @@ -84,7 +96,9 @@ module(

test('it adds class for minimal appearance', async function (assert) {
await render(
hbs`<Button @appearance="minimal" data-test-id="button">My Button</Button>`
<template>
<Button @appearance="minimal" data-test-id="button">My Button</Button>
</template>
);

assert.dom('[data-test-id="button"]').doesNotHaveClass('btn');
Expand All @@ -97,7 +111,9 @@ module(

test('it adds class for custom appearance', async function (assert) {
await render(
hbs`<Button @appearance="custom" data-test-id="button">My Button</Button>`
<template>
<Button @appearance="custom" data-test-id="button">My Button</Button>
</template>
);

assert.dom('[data-test-id="button"]').doesNotHaveClass('btn');
Expand All @@ -112,7 +128,9 @@ module(
module('@intent', () => {
test('it adds class for the an intent', async function (assert) {
await render(
hbs`<Button @intent="primary" data-test-id="button">My Button</Button>`
<template>
<Button @intent="primary" data-test-id="button">My Button</Button>
</template>
);

assert.dom('[data-test-id="button"]').hasClass('intent-primary');
Expand All @@ -122,15 +140,19 @@ module(
module('sizes', () => {
test('it adds class size xs"', async function (assert) {
await render(
hbs`<Button @size="xs" data-test-id="button">My Button</Button>`
<template>
<Button @size="xs" data-test-id="button">My Button</Button>
</template>
);

assert.dom('[data-test-id="button"]').hasClass('btn-xs');
});

test('it adds class size xl', async function (assert) {
await render(
hbs`<Button @size="xl" data-test-id="button">My Button</Button>`
<template>
<Button @size="xl" data-test-id="button">My Button</Button>
</template>
);

assert.dom('[data-test-id="button"]').hasClass('btn-xl');
Expand All @@ -140,9 +162,11 @@ module(

test('it yields classNames when renderless', async function (assert) {
await render(
hbs`<Button @isRenderless={{true}} as |btn|>
<template>
<Button @isRenderless={{true}} as |btn|>
<div data-test-id="my-div">{{btn.classNames}}</div>
</Button>`
</Button>
</template>
);
assert
.dom('[data-test-id="my-div"]')
Expand Down
53 changes: 33 additions & 20 deletions ...tegration/components/buttons/chip-test.ts → ...egration/components/buttons/chip-test.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
import { render } from '@ember/test-helpers';
import hbs from 'htmlbars-inline-precompile';
import { registerCustomStyles } from '@frontile/theme';
import { tv } from 'tailwind-variants';
import { Chip } from '@frontile/buttons';

registerCustomStyles({
chip: tv({
Expand Down Expand Up @@ -49,15 +49,23 @@ module('Integration | Component | Chip | @frontile/buttons', function (hooks) {
setupRenderingTest(hooks);

test('it renders', async function (assert) {
await render(hbs`<Chip data-test-id="button">My Chip</Chip>`);
await render(
<template>
<Chip data-test-id="button">My Chip</Chip>
</template>
);

assert.dom('[data-test-id="button"]').hasText('My Chip');
});

module('Style classes', () => {
module('@appearance', () => {
test('it adds class for default appearance', async function (assert) {
await render(hbs`<Chip data-test-id="button">My Chip</Chip>`);
await render(
<template>
<Chip data-test-id="button">My Chip</Chip>
</template>
);

assert.dom('[data-test-id="button"]').doesNotHaveClass('chip-outlined');
assert.dom('[data-test-id="button"]').doesNotHaveClass('chip-faded');
Expand All @@ -66,7 +74,9 @@ module('Integration | Component | Chip | @frontile/buttons', function (hooks) {

test('it adds class for outlined appearance', async function (assert) {
await render(
hbs`<Chip @appearance="outlined" data-test-id="button">My Chip</Chip>`
<template>
<Chip @appearance="outlined" data-test-id="button">My Chip</Chip>
</template>
);

assert.dom('[data-test-id="button"]').doesNotHaveClass('chip-default');
Expand All @@ -76,29 +86,23 @@ module('Integration | Component | Chip | @frontile/buttons', function (hooks) {

test('it adds class for faded appearance', async function (assert) {
await render(
hbs`<Chip @appearance="faded" data-test-id="button">My Chip</Chip>`
<template>
<Chip @appearance="faded" data-test-id="button">My Chip</Chip>
</template>
);

assert.dom('[data-test-id="button"]').doesNotHaveClass('chip-default');
assert.dom('[data-test-id="button"]').doesNotHaveClass('chip-outlined');
assert.dom('[data-test-id="button"]').hasClass('chip-faded');
});

test('it adds class for custom appearance', async function (assert) {
await render(
hbs`<Chip @appearance="custom" data-test-id="button">My Chip</Chip>`
);

assert.dom('[data-test-id="button"]').doesNotHaveClass('chip-default');
assert.dom('[data-test-id="button"]').doesNotHaveClass('chip-outlined');
assert.dom('[data-test-id="button"]').doesNotHaveClass('chip-faded');
});
});

module('@intent', () => {
test('it adds class for the an intent', async function (assert) {
await render(
hbs`<Chip @intent="primary" data-test-id="button">My Chip</Chip>`
<template>
<Chip @intent="primary" data-test-id="button">My Chip</Chip>
</template>
);

assert.dom('[data-test-id="button"]').hasClass('intent-primary');
Expand All @@ -108,15 +112,19 @@ module('Integration | Component | Chip | @frontile/buttons', function (hooks) {
module('@size', () => {
test('it adds class size sm"', async function (assert) {
await render(
hbs`<Chip @size="sm" data-test-id="button">My Chip</Chip>`
<template>
<Chip @size="sm" data-test-id="button">My Chip</Chip>
</template>
);

assert.dom('[data-test-id="button"]').hasClass('chip-sm');
});

test('it adds class size lg', async function (assert) {
await render(
hbs`<Chip @size="lg" data-test-id="button">My Chip</Chip>`
<template>
<Chip @size="lg" data-test-id="button">My Chip</Chip>
</template>
);

assert.dom('[data-test-id="button"]').hasClass('chip-lg');
Expand All @@ -126,7 +134,9 @@ module('Integration | Component | Chip | @frontile/buttons', function (hooks) {
module('@withDot', () => {
test('it adds dot when argument is passed in', async function (assert) {
await render(
hbs`<Chip @withDot={{true}} data-test-id="button">My Chip</Chip>`
<template>
<Chip @withDot={{true}} data-test-id="button">My Chip</Chip>
</template>
);

assert.dom('[data-test-id="button"] .chip-dot').exists();
Expand All @@ -135,8 +145,11 @@ module('Integration | Component | Chip | @frontile/buttons', function (hooks) {

module('@onClose', () => {
test('adds close button when onClose argument is passed in', async function (assert) {
const onClose = () => {};
await render(
hbs`<Chip @onClose={{true}} data-test-id="button">My Chip</Chip>`
<template>
<Chip @onClose={{onClose}} data-test-id="button">My Chip</Chip>
</template>
);

assert.dom('[data-test-id="button"] .chip-close-button').exists();
Expand Down
Loading
Loading