Skip to content

Conversation

reneleonhardt
Copy link
Contributor

Updated

  • Update cargo dependencies
  • Prepare for hyper v1 upgrade
  • Update go dependencies
  • Update docker dependencies
  • Fix some clippy warnings
  • Fix docker build
  • Let dependabot update cargo, gomod, npm, docker, github-actions

Not updated

  • hyper v1
  • opentelemetry

@vlad-ivanov-name
Copy link
Collaborator

Thank you for the PR! I will re-push to start the workflows, and will make some adjustments for the code.

@vlad-ivanov-name
Copy link
Collaborator

vlad-ivanov-name commented Aug 24, 2025

Newer versions of graphql crates change the order of properties in introspection responses (or maybe it's in the tooling?), here is a diff of normalized graphql schema:

diff
tests/proxy/graphql_schema.t.err.json --- 1/7 --- JSON
3  3     "data": {
4  4       "__schema": {
5  5         "directives": [
.  6           {
.  7             "args": [
.  8               {
.  9                 "defaultValue": null,
. 10                 "description": null,
. 11                 "name": "reason",
. 12                 "type": {
. 13                   "kind": "NON_NULL",
. 14                   "name": null,
. 15                   "ofType": {
. 16                     "kind": "SCALAR",
. 17                     "name": "String",
. 18                     "ofType": null
. 19                   }
. 20                 }
. 21               }
. 22             ],
. 23             "description": null,
. 24             "locations": [
. 25               "FIELD_DEFINITION",
. 26               "ENUM_VALUE"
. 27             ],
. 28             "name": "deprecated"
. 29           },
6 30           {
7 31             "args": [
8 32               {

tests/proxy/graphql_schema.t.err.json --- 2/7 --- JSON
52 76 "INLINE_FRAGMENT"
53 77 ],
54 78 "name": "skip"
55 79 },
.. 80 {
.. 81 "args": [
.. 82 {
.. 83 "defaultValue": null,
.. 84 "description": null,
.. 85 "name": "url",
.. 86 "type": {
.. 87 "kind": "NON_NULL",
.. 88 "name": null,
.. 89 "ofType": {
.. 90 "kind": "SCALAR",
.. 91 "name": "String",
.. 92 "ofType": null
.. 93 }
.. 94 }
.. 95 }
.. 96 ],
.. 97 "description": null,
.. 98 "locations": [
.. 99 "SCALAR"
.. 100 ],
.. 101 "name": "specifiedBy"
.. 102 }
56 103 ],
57 104 "mutationType": {
58 105 "name": "RepositoryMut"

tests/proxy/graphql_schema.t.err.json --- 3/7 --- JSON
1558 1605 }
1559 1606 }
1560 1607 },
.... 1608 {
.... 1609 "args": [],
.... 1610 "deprecationReason": null,
.... 1611 "description": null,
.... 1612 "isDeprecated": false,
.... 1613 "name": "isRepeatable",
.... 1614 "type": {
.... 1615 "kind": "NON_NULL",
.... 1616 "name": null,
.... 1617 "ofType": {
.... 1618 "kind": "SCALAR",
.... 1619 "name": "Boolean",
.... 1620 "ofType": null
.... 1621 }
.... 1622 }
.... 1623 },
1561 1624 {
1562 1625 "args": [],
1563 1626 "deprecationReason": null,

tests/proxy/graphql_schema.t.err.json --- 4/7 --- JSON
1664 1727 "isDeprecated": false,
1665 1728 "name": "FIELD"
1666 1729 },
.... 1730 {
.... 1731 "deprecationReason": null,
.... 1732 "description": null,
.... 1733 "isDeprecated": false,
.... 1734 "name": "SCALAR"
.... 1735 },
1667 1736 {
1668 1737 "deprecationReason": null,
1669 1738 "description": null,
1670 1739 "isDeprecated": false,
1671 1740 "name": "FRAGMENT_DEFINITION"
1672 1741 },
.... 1742 {
.... 1743 "deprecationReason": null,
.... 1744 "description": null,
.... 1745 "isDeprecated": false,
.... 1746 "name": "FIELD_DEFINITION"
.... 1747 },
.... 1748 {
.... 1749 "deprecationReason": null,
.... 1750 "description": null,
.... 1751 "isDeprecated": false,
.... 1752 "name": "VARIABLE_DEFINITION"
.... 1753 },
1673 1754 {
1674 1755 "deprecationReason": null,
1675 1756 "description": null,

tests/proxy/graphql_schema.t.err.json --- 5/7 --- JSON
1681 1762 "description": null,
1682 1763 "isDeprecated": false,
1683 1764 "name": "INLINE_FRAGMENT"
1684 1765 },
.... 1766 {
.... 1767 "deprecationReason": null,
.... 1768 "description": null,
.... 1769 "isDeprecated": false,
.... 1770 "name": "ENUM_VALUE"
.... 1771 }
1685 1772 ],
1686 1773 "fields": null,
1687 1774 "inputFields": null,

tests/proxy/graphql_schema.t.err.json --- 6/7 --- JSON
1935 2022 "description": null,
1936 2023 "enumValues": null,
1937 2024 "fields": [
.... 2025 {
.... 2026 "args": [],
.... 2027 "deprecationReason": null,
.... 2028 "description": null,
.... 2029 "isDeprecated": false,
.... 2030 "name": "description",
.... 2031 "type": {
.... 2032 "kind": "SCALAR",
.... 2033 "name": "String",
.... 2034 "ofType": null
.... 2035 }
.... 2036 },
1938 2037 {
1939 2038 "args": [],
1940 2039 "deprecationReason": null,

tests/proxy/graphql_schema.t.err.json --- 7/7 --- JSON
2058 2157 "ofType": null
2059 2158 }
2060 2159 },
.... 2160 {
.... 2161 "args": [],
.... 2162 "deprecationReason": null,
.... 2163 "description": null,
.... 2164 "isDeprecated": false,
.... 2165 "name": "specifiedByUrl",
.... 2166 "type": {
.... 2167 "kind": "SCALAR",
.... 2168 "name": "String",
.... 2169 "ofType": null
.... 2170 }
.... 2171 },
2061 2172 {
2062 2173 "args": [],
2063 2174 "deprecationReason": null,

converted with LLM for better highlighting -- not a valid diff
--- a/tests/proxy/graphql_schema.t.err.json
+++ b/tests/proxy/graphql_schema.t.err.json
@@ -3,6 +3,29 @@
     "data": {
       "__schema": {
         "directives": [
+          {
+            "args": [
+              {
+                "defaultValue": null,
+                "description": null,
+                "name": "reason",
+                "type": {
+                  "kind": "NON_NULL",
+                  "name": null,
+                  "ofType": {
+                    "kind": "SCALAR",
+                    "name": "String",
+                    "ofType": null
+                  }
+                }
+              }
+            ],
+            "description": null,
+            "locations": [
+              "FIELD_DEFINITION",
+              "ENUM_VALUE"
+            ],
+            "name": "deprecated"
+          },
           {
             "args": [
               {
@@ -53,6 +76,28 @@
               "INLINE_FRAGMENT"
             ],
             "name": "skip"
+          },
+          {
+            "args": [
+              {
+                "defaultValue": null,
+                "description": null,
+                "name": "url",
+                "type": {
+                  "kind": "NON_NULL",
+                  "name": null,
+                  "ofType": {
+                    "kind": "SCALAR",
+                    "name": "String",
+                    "ofType": null
+                  }
+                }
+              }
+            ],
+            "description": null,
+            "locations": [
+              "SCALAR"
+            ],
+            "name": "specifiedBy"
           }
         ],
         "mutationType": {
@@ -1558,6 +1603,20 @@
                   }
                 }
               },
+              {
+                "args": [],
+                "deprecationReason": null,
+                "description": null,
+                "isDeprecated": false,
+                "name": "isRepeatable",
+                "type": {
+                  "kind": "NON_NULL",
+                  "name": null,
+                  "ofType": {
+                    "kind": "SCALAR",
+                    "name": "Boolean",
+                    "ofType": null
+                  }
+                }
+              },
               {
                 "args": [],
                 "deprecationReason": null,
@@ -1664,12 +1723,33 @@
                 "isDeprecated": false,
                 "name": "FIELD"
               },
+              {
+                "deprecationReason": null,
+                "description": null,
+                "isDeprecated": false,
+                "name": "SCALAR"
+              },
               {
                 "deprecationReason": null,
                 "description": null,
                 "isDeprecated": false,
                 "name": "FRAGMENT_DEFINITION"
               },
+              {
+                "deprecationReason": null,
+                "description": null,
+                "isDeprecated": false,
+                "name": "FIELD_DEFINITION"
+              },
+              {
+                "deprecationReason": null,
+                "description": null,
+                "isDeprecated": false,
+                "name": "VARIABLE_DEFINITION"
+              },
               {
                 "deprecationReason": null,
                 "description": null,
@@ -1681,6 +1761,12 @@
                 "description": null,
                 "isDeprecated": false,
                 "name": "INLINE_FRAGMENT"
+              },
+              {
+                "deprecationReason": null,
+                "description": null,
+                "isDeprecated": false,
+                "name": "ENUM_VALUE"
               }
             ],
             "fields": null,
@@ -1935,6 +2021,17 @@
             "description": null,
             "enumValues": null,
             "fields": [
+              {
+                "args": [],
+                "deprecationReason": null,
+                "description": null,
+                "isDeprecated": false,
+                "name": "description",
+                "type": {
+                  "kind": "SCALAR",
+                  "name": "String",
+                  "ofType": null
+                }
+              },
               {
                 "args": [],
                 "deprecationReason": null,
@@ -2058,6 +2155,17 @@
                   "ofType": null
                 }
               },
+              {
+                "args": [],
+                "deprecationReason": null,
+                "description": null,
+                "isDeprecated": false,
+                "name": "specifiedByUrl",
+                "type": {
+                  "kind": "SCALAR",
+                  "name": "String",
+                  "ofType": null
+                }
+              },
               {
                 "args": [],
                 "deprecationReason": null,

@vlad-ivanov-name
Copy link
Collaborator

verified the release container.

@vlad-ivanov-name
Copy link
Collaborator

merging -- thanks again!

@vlad-ivanov-name vlad-ivanov-name merged commit 091c2dc into josh-project:master Aug 24, 2025
1 check passed
@vlad-ivanov-name
Copy link
Collaborator

opentelemetry

Just confirmed -- we can remove jaeger crates, since jaeger now supports ingestion of otel. This will allow to upgrade all related crates.

@reneleonhardt reneleonhardt deleted the chore/update-dependencies branch August 25, 2025 13:18
@reneleonhardt
Copy link
Contributor Author

Great to see that you could fix all remaining problems!

Because many crates are unmaintained, are you open to using alternatives?
hyper 1.0.0 has been released 2 years ago for example.
felipenoris/hyper-reverse-proxy#54

@vlad-ivanov-name
Copy link
Collaborator

Yes, any maintained alternatives are fine, as long as it doesn't blow up Cargo.lock too much -- that's the main concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants