Skip to content

Mariculture 1.2.x patches (for Regrowth modpack)#371

Open
asiekierka wants to merge 8 commits intojoshiejack:1.7.10-1.2.4from
asiekierka:1.7.10-1.2.4
Open

Mariculture 1.2.x patches (for Regrowth modpack)#371
asiekierka wants to merge 8 commits intojoshiejack:1.7.10-1.2.4from
asiekierka:1.7.10-1.2.4

Conversation

@asiekierka
Copy link

@asiekierka asiekierka commented Jun 10, 2023

  • Update bundled CoFH API from 1.0.2 to 1.3.1 (old versions of the API like to throw off other mods),
  • Backport ganymedes01's fluid fixes from the 1.3.0 branch,
  • Fix a few potential NPEs (PacketAirPump not being potential) in networking code,
  • Fix DNA Injector not being craftable,
  • Reintroduce (behind a configuration option) "forgotten fish breeding recipes" (I have no idea what @grompe was referring to here exactly, I'm just merging the Regrowth team's existing changes here).
  • Make the repository actually build in 2023. (You'll still need to force JDK 8, though.)

We plan to ship these changes in Regrowth 1.1.0, but I've decided to open a PR in case anyone else ever finds them useful.

@brandyyn
Copy link

crash-2025-07-20_21.02.42-server.txt
any chance this could be looked at? @asiekierka, I'm using your PR and i'm unsure if it's a base issue with mariculture or with your fork, i've had this crash a few times now.

@asiekierka
Copy link
Author

A quick check suggests this is a novel bug, that is not affected by my PR.

@Omgise
Copy link

Omgise commented Aug 3, 2025

Is it possible for you to fix the texture issues for all fishing rods in the Mariculture mod? After casting, the hook and fishing line still remain on the rod.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants