feat: Implement interactive popup dragging and resizing #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 1, 2025 03:42
This commit introduces interactive dragging and resizing functionality to the `tui-popup` crate. Changes include: - Added an `interactive` example demonstrating the new features. - Updated `PopupState` to manage interaction state (dragging and resizing). - Modified `Popup` widget to render a resize handle. - Implemented mouse event handling for dragging and resizing. - Added constraints to keep the popup within terminal bounds and enforce minimum size. These changes allow users to interactively reposition and resize popups within the terminal, improving the user experience.
This commit introduces several enhancements to the `tui-popup` crate, focusing on improved user interaction and visual feedback: - Add a resize handle to the popup, allowing users to resize it by dragging. - Implement mouse event handling for dragging and resizing the popup. - Introduce `move_to_*` methods in `PopupState` to allow moving the popup to specific screen edges. - Enhance the resize handle with hover effects for improved visual feedback. - Fix: Correctly clamp resize values to terminal size and minimum dimensions. - Fix: Address issue where resize handle wasn't being correctly styled. - Add Ctrl+Arrow keybindings to move popup to screen edges in state example.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 71.51% 72.28% +0.76%
==========================================
Files 15 15
Lines 2503 2742 +239
==========================================
+ Hits 1790 1982 +192
- Misses 713 760 +47 ☔ View full report in Codecov by Sentry. |
This commit introduces several enhancements to the interactive popup example and the `tui-popup` crate: - Adds keyboard controls for moving the popup using arrow keys or hjkl, with Ctrl+Arrow for jumping to edges. - Implements a help popup that displays keyboard shortcuts, toggled with the '?' key. - Implements a reset position function to move the popup to the default position. - Adds a status bar to display the popup's position and mode (Normal/Help). - Implements a close button on the popup title bar. - Refactors the example code for better readability and structure. - Fixes and improves the rendering tests. These changes improve the user experience by providing alternative input methods and making the popup more informative and easier to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces interactive dragging and resizing functionality to the
tui-popupcrate.Changes include:
interactiveexample demonstrating the new features.PopupStateto manage interaction state (dragging and resizing).Popupwidget to render a resize handle.These changes allow users to interactively reposition and resize popups within the terminal, improving the user experience.