Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement validate_sql #7

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Implement validate_sql #7

wants to merge 1 commit into from

Conversation

joshtemple
Copy link
Owner

@joshtemple joshtemple commented Jan 13, 2024

Closes #6.

@joshtemple
Copy link
Owner Author

@tconbeer would appreciate you taking a look at this WIP. I'm not sure I've done it right. Doesn't the code need to return an error message or anything like that from the database?

@tconbeer
Copy link
Contributor

No, you've got it right. It's kind of un-Pythonic but returning the empty string on error is expected. You'll know it's working if you highlight a valid query and the "Run Query" button says "Run Selection" instead. It should still show "Run Query" if the selected text isn't a valid query.

Repository owner deleted a comment from uc-Pri Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support validate_sql
2 participants