Refactor addVo to follow skeleton_TA structure#108
Closed
erichung0404 wants to merge 3 commits into
Closed
Conversation
As chartSeries is now a wrapper for chart_Series and chartSeries.chob is deprecated, code of add* functions that manipulate chob and chobTA objects breaks. So add* functions are refactored to use skeleton_TA structure to coordinate with chart_Series called by chartSeries. In addVo.R, however, quantmod::chartVo is untouched. A new chartVo is passed to lenv environment in addVo according to skeleton_TA structure. quantmod::chartVo will be deprecated.
When subset is specified in chartSeries, addVo() doesn't apply correct subset volume to the chart. To fix this issue, subset setting is applied to chartVo function in chartSeries and pass subset volume to the environment. y-axis limit of the frame is expanded to reserve space from the top.
When reChart is called to draw subset volume, bar colors are wrong and subset functionality fails. The volume chart starts from the first day of the series no matter what subset period is specified. Pull out the panel settings from chartVo and wrap in expression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since chartSeries is now a wrapper for chart_Series and chartSeries.chob
is deprecated, code of add* functions that manipulate chob and chobTA
objects breaks. So add* functions are refactored to use skeleton_TA
structure to coordinate with chart_Series called by chartSeries.
In addVo.R, however, quantmod::chartVo is untouched. A new chartVo is
passed to lenv inside addVo function according to skeleton_TA structure.
quantmod::chartVo will be deprecated. The structure is described in #96.