Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing name parameter in calendar_heatmap #133

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

gutjuri
Copy link
Contributor

@gutjuri gutjuri commented Mar 7, 2024

When calling calendar_heatmap I got an error that this line:

.join(df_day, on="date", how="left")

failed. This PR fixes this issue by manually setting the novel dataframe's columnname to "date" (previously it was "literal" for some reason.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.34%. Comparing base (b7d0ea6) to head (417e554).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files           1        1           
  Lines         259      259           
=======================================
  Hits          234      234           
  Misses         25       25           
Flag Coverage Δ
unittests 90.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@joweich joweich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gutjuri, I can't reproduce this on polars v0.20.2, this might be an issue on other versions only. However, I agree that we should set the column title explicitly for codestyle reasons. Thank you for your 5th contribution to this project! 🚀

@joweich joweich merged commit 08de7c3 into joweich:main Mar 10, 2024
10 checks passed
@gutjuri
Copy link
Contributor Author

gutjuri commented Mar 11, 2024

pip install polars installed version 0.20.14 for me. Thanks for merging. Wasn't aware that this was my 5th contribution already ;P Time flies :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants