Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQS-142 fdb metrics should only include process data for existing processes #1

Merged
merged 1 commit into from
Mar 14, 2024
Merged

SQS-142 fdb metrics should only include process data for existing processes #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions models/process.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,60 @@ var (

// ExportProcesses is exporting the configuration
func (s FDBStatus) ExportProcesses() {
// We .Reset() all the metrics here in order that we clear out any no-longer running processes.
// Without this, we'll continue to build up metrics over time for processes that no longer exist
// and the only way to clear those out otherwise is to restart.
processCPUInfo.Reset()
processDiskInfoBusy.Reset()
processDiskInfoFreeBytes.Reset()
processDiskInfoReadHZ.Reset()
processDiskInfoReadTotal.Reset()
processDiskInfoTotalBytes.Reset()
processDiskInfoWriteHZ.Reset()
processDiskInfoWritesTotal.Reset()
processMemoryInfoAvailableBytes.Reset()
processMemoryInfoLimitBytes.Reset()
processMemoryInfoUnusedMemory.Reset()
processMemoryInfoUsedBytes.Reset()
processNetworkConnectionError.Reset()
processNetworkConnectionsClosed.Reset()
processNetworkConnectionsEstablished.Reset()
processNetworkCurrentConnection.Reset()
processNetworkReceived.Reset()
processNetworkSent.Reset()
logRoleDataVersion.Reset()
logRoleDurableBytesHZ.Reset()
logRoleDurableBytesCounter.Reset()
logRoleAvailableBytes.Reset()
logRoleFreeBytes.Reset()
logRoleTotalBytes.Reset()
logRoleUsedBytes.Reset()
logRoleQueueAvailableBytes.Reset()
logRoleQueueFreeBytes.Reset()
logRoleQueueTotalBytes.Reset()
logRoleQueueUsedbytes.Reset()
storageRoleBytesQueriedHz.Reset()
storageRoleBytesQueriedCounter.Reset()
storageRoleDataLagSeconds.Reset()
storageRoleDataLagVersions.Reset()
storageRoleDurabilityLagSeconds.Reset()
storageRoleDurabilityLagVersions.Reset()
storageRoleDurableVersions.Reset()
storageRoleFinishedQueriesCounter.Reset()
storageRoleFinishedQueriesHz.Reset()
storageRoleInputBytesCounter.Reset()
storageRoleInputBytesHz.Reset()
storageRoleKeysQueriedCounter.Reset()
storageRoleKeysQueriedHz.Reset()
storageRoleMutationsCounter.Reset()
storageRoleMutationHz.Reset()
storageRoleMutationsBytesCounter.Reset()
storageRoleMutationBytesHz.Reset()
storageRoleTotalQueriesCounter.Reset()
storageRoleTotalQueriesHz.Reset()
storageRoleQueryMaxQueue.Reset()
storageRoleStoredBytes.Reset()

for process, info := range s.Cluster.Processes {
processCPUInfo.With(prometheus.Labels{
"process_id": process,
Expand Down