Skip to content

File cleaning and loading issues#4

Draft
jpaulpoliquit wants to merge 3 commits intomasterfrom
cursor/file-cleaning-and-loading-issues-b50d
Draft

File cleaning and loading issues#4
jpaulpoliquit wants to merge 3 commits intomasterfrom
cursor/file-cleaning-and-loading-issues-b50d

Conversation

@jpaulpoliquit
Copy link
Copy Markdown
Owner

@jpaulpoliquit jpaulpoliquit commented Jan 22, 2026

Description

This PR introduces a new specification document (SPEC_CLEANING_LOADING_STALLS.md) detailing the investigation into reported issues where file cleaning operations get stuck and the loading indicator freezes. The spec outlines observed behavior, identifies likely root causes, and proposes an investigation and mitigation plan.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements

Related Issues

Closes #
Related to #

Changes Made

  • Added SPEC_CLEANING_LOADING_STALLS.md to document the investigation into cleaning stalls and loading indicator freezes.
  • The spec covers: observed behavior, key code paths, likely root causes (hypotheses), an investigation plan, and a mitigation plan.

Testing

  • All existing tests pass
  • Added new tests for new functionality
  • Tested manually on Windows [version]
  • Tested with different categories/flags

Test commands:

# Add test commands here
cargo test
wole scan --all

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • Code is commented, particularly in hard-to-understand areas
  • Documentation updated (README, doc comments, etc.)
  • No new warnings generated
  • Tests added/updated and passing
  • All CI checks pass
  • Changes are backward compatible (if applicable)

Screenshots/Output

Example output here

Additional Notes

This PR is solely for the addition of the investigation specification. Implementation of the proposed mitigations will follow in subsequent PRs.


Open in Cursor Open in Web


Note

Improves TUI cleaning responsiveness and documents known stall issues.

  • Introduces run_blocking_with_spinner(...) to execute blocking work on a worker thread while periodically updating tick and redrawing, preventing spinner freezes
  • Applies the helper to trash purge, application uninstall, Windows Update/Event Logs cleaning, and batch deletions (temp/general) by passing captured path batches
  • Splits items into additional category-specific flows (Windows Update, Event Logs) with dedicated cleanup calls and logging
  • Enhances progress updates during batch processing (smaller chunks, redraw cadence) and maintains history logging
  • Adds SPEC_CLEANING_LOADING_STALLS.md detailing observed behavior, hypotheses, investigation, and mitigation plan

Written by Cursor Bugbot for commit d35ff81. This will update automatically on new commits. Configure here.

@cursor
Copy link
Copy Markdown

cursor bot commented Jan 22, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is ON. A Cloud Agent has been kicked off to fix the reported issue.

Comment thread src/tui/mod.rs Outdated
@cursor
Copy link
Copy Markdown

cursor bot commented Jan 22, 2026

Bugbot Autofix resolved the bug found in the latest run.

  • ✅ Fixed: Windows Update and Event Logs incorrectly use user's permanent flag
    • Windows Update and Event Logs now always log history entries as permanent to prevent restore from offering non-restorable operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants