feat: add confidence badge on result card#51
Conversation
|
@aditikhushi81-cpu is attempting to deploy a commit to the karan3431's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
🎉 Thank you for your Pull Request! We're thrilled to have your contribution to FreshScan AI. Before we review, please make sure you have:
A maintainer will review your code as soon as possible! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
jpdevhub
left a comment
jpdevhub
left a comment
There was a problem hiding this comment.
Great start, Aditi! The logic works perfectly and flex-wrap was a good call. However, before we can merge this, we need to make sure the styling matches the rest of our custom design system. Could you please update the following Let me know when you've pushed these updates and I will get it merged!
| <span | ||
| className={`px-2 py-1 rounded-md text-xs font-semibold ${ | ||
| confidence < 70 | ||
| ? "bg-yellow-500/20 text-yellow-400 border border-yellow-500/30" |
There was a problem hiding this comment.
Avoid hardcoded Tailwind colors: We don't use default colors like green-500 or yellow-500 because they break our Light/Dark mode themes. Please use our custom theme variables (e.g., text-neon and text-error).
| </span> | ||
|
|
||
| <span | ||
| className={`px-2 py-1 rounded-md text-xs font-semibold ${ |
There was a problem hiding this comment.
Remove rounded corners: Our UI uses sharp edges. Please remove the rounded-md class from the badge to maintain the brutalist aesthetic.
| : "bg-green-500/20 text-green-400 border border-green-500/30" | ||
| }`} | ||
| > | ||
| {confidence < 70 ? "Low Confidence" : "High Confidence"} |
There was a problem hiding this comment.
Match the Typography: The rest of the metrics use our mono font and uppercase tracking text. Instead of "High Confidence", please use HIGH_CONFIDENCE with the font-[family-name:var(--font-mono)] and tracking-widest classes so it looks like a terminal output.
| CLASSIFICATION: {classification} | ||
| </span> | ||
|
|
||
| <span className="font-[family-name:var(--font-mono)] text-[0.5625rem] text-on-surface-variant tracking-widest"> |
There was a problem hiding this comment.
Fix the Indentation: The newly added elements inside the flex div have lost their indentation and are flushed completely to the left edge of the file. Please format the code so the indentation aligns correctly with the surrounding React code.
|
Hi @jpdevhub, I've addressed all requested review comments: The changes have been pushed. Please review when convenient. Thank you! |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ditikhushi81-cpu/main
… the development server
|
Dont make main branch in any project it can crash whole system. Rest of the things are okk and fine |
|
In the pr description give your issue no. with #closes tag so that it will closes issue we are ready to merge ! |
|
Actually it was #49 your issue what i assigned |
|
Thanks for contribution. I am merging this pr |
|
Dont forget to star the repo and take more issues and contribute more! |
|
You are not in the official contributer list |
2 participants
Description
Added a confidence badge on the Analysis Dashboard result card.
Changes
Summary by cubic
Added a confidence badge to the Analysis Dashboard result card to make model certainty clear at a glance. Shows "Low Confidence" below 70% and "High Confidence" at 70%+ with color cues.
Written for commit 1627824. Summary will update on new commits.
Closes #49