feat(ui): implement skeleton loaders for market map and leaderboard#67
Conversation
- Created reusable brutalist Skeleton component - Replaced 'DOWNLOADING_NODES...' text with skeleton UI in MarketMapPage - Updated loading states to match GlassCard dimensions and prevent layout shift Resolves jpdevhub#60
…classname for font
|
@Mohammad-Hassan027 is attempting to deploy a commit to the karan3431's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
🎉 Thank you for your Pull Request! We're thrilled to have your contribution to FreshScan AI. Before we review, please make sure you have:
A maintainer will review your code as soon as possible! |
|
Leaderboard Loader
|
Mohammad-Hassan027
left a comment
There was a problem hiding this comment.
Ready to merge
|
Great work on this! The component is perfectly minimal and fits the brutalist aesthetic exactly how we want it (flat colors, no rounded corners). The implementation on the MarketMapPage looks and feels great! Could you please: Fetch/pull the latest main branch (we recently merged the new Leaderboard.tsx page). |
- Created reusable brutalist Skeleton component - Replaced 'DOWNLOADING_NODES...' text with skeleton UI in MarketMapPage - Updated loading states to match GlassCard dimensions and prevent layout shift Resolves jpdevhub#60
…classname for font
…d-Hassan027/FreshScanAi into feat/60-skeleton-loaders
|
Hey @jpdevhub , thanks for the great feedback! I've just pulled the latest The changes have been pushed and the PR should be good to go. Let me know if you need anything else! |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I am merging it but you are not register as a contributer in the SSoc new website fix that. |
jpdevhub
left a comment
There was a problem hiding this comment.
Perfect, thanks for contributing.
I have registered but that features are down in ssoc. |
|
Yes, your name is not currently in contributer list you have not registered previously that's what I was saying. Good to know you have have filled master form. |
Created reusable brutalist Skeleton component
DOWNLOADING_NODES...text with skeleton UI in MarketMapPageResolves #60
Description
This PR addresses issue #60 by improving the perceived performance of data-fetching states across the application. I am submitting this contribution as part of SSoC26.
Changes included:
Skeleton.tsxComponent: Created a new, reusable brutalist/cyberpunk skeleton component utilizing thebg-surface-midcolor class and a smooth pulse animation.MarketMapPage.tsx: Removed the generic "DOWNLOADING_NODES..." text. Implemented the new Skeleton loader structured to mimic the exact dimensions of the GlassCard component. This ensures a seamless transition with zero layout shift when the market data finishes loading.Leaderboard.tsx: (If you completed this part) Replaced the fetching state with skeleton rows that map directly to the table column widths.Screenshots/Video
wait ..
Checklist
npm run lintpasses with no errorsnpm run buildcompiles without TypeScript errorspython -m pytestpasses.envfiles, API keys, secrets, model weights, or__pycache__in this diffmain, not merged