-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: convert babel plugin to typescript #570
feat: convert babel plugin to typescript #570
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Great addition! I will happily accept it 🙏 Small note: keep strings single quoted |
46d67cf
to
b5ebe50
Compare
b5ebe50
to
c2e2151
Compare
99ceb62
to
c84b94e
Compare
6a68aaa
to
f5bb4aa
Compare
I have my own AST debugger online but it's limited to single file.
So it can be a |
That's ok. They are computed based on file name and extension. Thanks for the help! PR looks solid 🚀 |
Tested it locally, looks awesome. Thanks @jeremybarbet for cool contribution 🙏 |
You're very welcome, pleasure to make a small contribution to this great project! |
Released as |
Summary
The main reason of my previous PRs regarding formatting was for me to contribute to this one.
react-native-reanimated
, use esbuild to bundle the javascript plugin fileyarn precommit
or somethingNote: To make review easier, first commit is only converting
.js
to.ts
and moving them to a/src
folder