Skip to content

Shortening improvements (+ iPad support) #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markruys wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Shortening improvements (+ iPad support) #27

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d1849de
Fixed shorten and post a tweet when not authorized.
Dec 29, 2011
92b68fb
Added iPad support
Dec 29, 2011
1923c36
Added Google and bitly as shorteners. Use set_shortener() to configure.
Dec 29, 2011
d57d4da
Pass error message from Twitter API to callback function.
Dec 30, 2011
a94978a
Call callback function even when dialog is cancelled.
Dec 30, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
189 changes: 140 additions & 49 deletions birdhouse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,8 @@
// --------------------------------------------------------

// INCLUDES
// iphone requires complete path
if (Ti.Platform.osname=='iphone') {
Ti.include('lib/oauth.js');
Ti.include('lib/sha1.js');
}
// android will search the current directory for files
else {
Ti.include('oauth.js');
Ti.include('sha1.js');
}
Ti.include('oauth.js');
Ti.include('sha1.js');

// THE CLASS
function BirdHouse(params) {
Expand All @@ -55,6 +47,7 @@ function BirdHouse(params) {
request_verifier: "",
access_token: "",
access_token_secret: "",
shortener: {},
callback_url: ""
};
var accessor = {
Expand All @@ -63,6 +56,11 @@ function BirdHouse(params) {
};
var authorized = false;

var osname = Ti.Platform.osname;
if ( osname === 'ipad' ) {
osname = 'iphone';
}

// --------------------------------------------------------
// set_message
//
Expand Down Expand Up @@ -143,7 +141,7 @@ function BirdHouse(params) {
fullscreen: true
});
// add close button on iPhone
if (Ti.Platform.osname=='iphone' && cfg.show_login_toolbar) {
if (osname=='iphone' && cfg.show_login_toolbar) {
var webView = Ti.UI.createWebView({
url: url,
scalesPageToFit: true,
Expand Down Expand Up @@ -472,6 +470,7 @@ function BirdHouse(params) {

// on success, grab the request token
XHR.onload = function() {
Ti.API.debug("api response " + XHR.responseText);

// execute the callback function
if (typeof(callback)=='function') {
Expand All @@ -483,15 +482,23 @@ function BirdHouse(params) {

// on error, show message
XHR.onerror = function(e) {
var message = null;
try {
message = JSON.parse(XHR.responseText).error;
}
catch (e) {
}
Ti.API.debug("api error " + XHR.status + (message ? ', ' + message : ''));
// execute the callback function
if (typeof(callback)=='function') {
callback(false);
callback(false, message);
}

return false;
}

XHR.open(method, finalUrl, false);
Ti.API.debug("api " + method + " " + finalUrl);

// if we are getting request tokens do not set the HTML header
if (typeof(setHeader)=='undefined' || setHeader==true) {
Expand All @@ -503,10 +510,11 @@ function BirdHouse(params) {
} else {
header = header + ",";
}
header = header + message.parameters[i][0] + '="' + escape(message.parameters[i][1]) + '"';
header = header + message.parameters[i][0] + '="' + Ti.Network.encodeURIComponent(message.parameters[i][1]) + '"';
}

XHR.setRequestHeader("Authorization", header);
Ti.API.debug("api Authorization: " + header);
}

XHR.send();
Expand Down Expand Up @@ -564,7 +572,7 @@ function BirdHouse(params) {

// the UI window looks completely different on iPhone vs. Android
// iPhone UI
if (Ti.Platform.osname=='iphone') {
if (osname=='iphone') {
var winTW = Titanium.UI.createWindow({
height:((Ti.Platform.displayCaps.platformHeight*0.5)-15), // half because the keyboard takes up half
width:(Ti.Platform.displayCaps.platformWidth-20),
Expand Down Expand Up @@ -666,17 +674,17 @@ function BirdHouse(params) {
charcount.text = parseInt(chars)+'';
});
btnTW.addEventListener('click',function() {
send_tweet("status="+escape(tweet.value),function(retval){
send_tweet("status="+escape(tweet.value),function(retval, message){
if (retval===false) {
// execute the callback function
if (typeof(callback)=='function') {
callback(false);
callback(false, message);
}

return false;
} else {
// hide the keyboard on Android because it doesn't automatically
if (Ti.Platform.osname=='android') {
if (osname=='android') {
Titanium.UI.Android.hideSoftKeyboard();
}

Expand All @@ -694,9 +702,15 @@ function BirdHouse(params) {
});
btnCancel.addEventListener('click',function() {
// hide the keyboard on Android because it doesn't automatically
if (Ti.Platform.osname=='android') {
if (osname=='android') {
Titanium.UI.Android.hideSoftKeyboard();
}

// execute the callback function
if (typeof(callback)==='function') {
callback(false);
}

winBG.close();
winTW.close();
});
Expand Down Expand Up @@ -739,7 +753,7 @@ function BirdHouse(params) {
if (authorized === false) {
authorize(function(resp){
if (resp) {
obj.tweet(obj.mytweet);
obj.short_tweet(obj.mytweet, callback);

return true;
} else {
Expand All @@ -762,7 +776,7 @@ function BirdHouse(params) {

// the UI window looks completely different on iPhone vs. Android
// iPhone UI
if (Ti.Platform.osname=='iphone') {
if (osname=='iphone') {
var winTW = Titanium.UI.createWindow({
height:((Ti.Platform.displayCaps.platformHeight*0.5)-15), // half because the keyboard takes up half
width:(Ti.Platform.displayCaps.platformWidth-20),
Expand Down Expand Up @@ -909,17 +923,17 @@ function BirdHouse(params) {
}
});
btnTW.addEventListener('click',function() {
send_tweet("status="+escape(tweet.value),function(retval){
send_tweet("status="+escape(tweet.value),function(retval, message){
if (retval===false) {
// execute the callback function
if (typeof(callback)=='function') {
callback(false);
callback(false, message);
}

return false;
} else {
// hide the keyboard on Android because it doesn't automatically
if (Ti.Platform.osname=='android') {
if (osname=='android') {
Titanium.UI.Android.hideSoftKeyboard();
}

Expand All @@ -937,9 +951,15 @@ function BirdHouse(params) {
});
btnCancel.addEventListener('click',function() {
// hide the keyboard on Android because it doesn't automatically
if (Ti.Platform.osname=='android') {
if (osname=='android') {
Titanium.UI.Android.hideSoftKeyboard();
}

// execute the callback function
if (typeof(callback)==='function') {
callback(false);
}

winBG.close();
winTW.close();
});
Expand All @@ -964,15 +984,15 @@ function BirdHouse(params) {
// callback (Function) - function to call on completion
// --------------------------------------------------------
function send_tweet(params,callback) {
api('http://api.twitter.com/1/statuses/update.json','POST',params,function(resp){
api('http://api.twitter.com/1/statuses/update.json','POST',params,function(resp, message){
if (resp!=false) {
if (typeof(callback)=='function') {
callback(true);
}
return true;
} else {
if (typeof(callback)=='function') {
callback(false);
callback(false, message);
}
return false;
}
Expand All @@ -983,48 +1003,118 @@ function BirdHouse(params) {
// --------------------------------------------------------
// shorten_url
//
// Shortens a URL using twe.ly.
// Shortens a URL.
//
// In Parameters:
// url (String) - the url to shorten
// callback (Function) - function to call on completion
//
// Returns:
// shorturl (String) - the shortened URL, else false
// callback (Function) - function to call on completion
// nothing
// --------------------------------------------------------
function shorten_url(url,callback) {
if ( typeof callback === 'function' ) {
switch ( cfg.shortener.type ) {
case 'twely':
shorten_url_twely(url, callback);
break;
case 'bitly':
shorten_url_bitly(url, callback);
break;
default:
shorten_url_google(url, callback);
break;
}
}
}


function shorten_url_google(longurl, callback) {
var XHR = Titanium.Network.createHTTPClient();
XHR.open("GET","http://www.twe.ly/short.php?url="+url+"&json=1");
XHR.open("POST", "https://www.googleapis.com/urlshortener/v1/url");
XHR.setRequestHeader('Content-Type', 'application/json');
XHR.onload = function () {
var shorturl = false;
try {
shorturl = JSON.parse(XHR.responseText);
} catch(e) {
shorturl = false;
var response = JSON.parse(XHR.responseText);
if ( typeof response === 'object' && response.id ) {
shorturl = response.id;
}
}

if (shorturl!=false && shorturl.substr(0,5)=='Sorry') {
shorturl = false;
catch(e) {
Ti.API.info("Exception while shortening " + longurl);
}
callback(shorturl, longurl);
};
XHR.onerror = function() {
Ti.API.info("Error while shortening " + longurl + " (" + XHR.status + ")");
callback(false);
};
XHR.send(JSON.stringify({longUrl: longurl}));
}

if (typeof(callback)=='function') {
callback(shorturl,url);
function shorten_url_twely(longurl, callback) {
var XHR = Titanium.Network.createHTTPClient();
XHR.open("GET", "http://www.twe.ly/short.php?json=1&url=" + Ti.Network.encodeURIComponent(longurl));
XHR.onload = function () {
var shorturl = false;
try {
var response = JSON.parse(XHR.responseText);
if ( typeof response === 'string' && response.substr(0,5) !== 'Sorry' ) {
shorturl = reponse;
}
}

return shorturl;
catch(e) {
Ti.API.info("Exception while shortening " + longurl);
}
callback(shorturl, longurl);
};
XHR.onerror = function(e) {

if (typeof(callback)=='function') {
callback(false);
XHR.onerror = function() {
Ti.API.info("Error while shortening " + longurl + " (" + XHR.status + ")");
callback(false);
};
XHR.send();
}

function shorten_url_bitly(longurl, callback) {
var XHR = Titanium.Network.createHTTPClient();
XHR.open("GET", "https://api-ssl.bitly.com/v3/shorten?login=" + cfg.shortener.username + "&apiKey=" + cfg.shortener.key + "&format=json&longUrl=" + Ti.Network.encodeURIComponent(longurl));
XHR.onload = function () {
var shorturl = false;
try {
var response = JSON.parse(XHR.responseText);
if ( typeof response === 'object' && response.status_code === 200 ) {
shorturl = response.data.url;
}
}

return false;
catch(e) {
Ti.API.info("Exception while shortening " + longurl);
}
callback(shorturl, longurl);
};
XHR.onerror = function() {
Ti.API.info("Error while shortening " + longurl + " (" + XHR.status + ")");
callback(false);
};
XHR.send();
}


// --------------------------------------------------------
// set_shortener
//
// Configure the shortener to be used.
//
// In Parameters:
// obj - object to configure the shortener
// type: string denoting the service used (e.g. 'google')
// username: string with username (if needed)
// key: string with ket (if needed)
//
// Returns: nothing
// --------------------------------------------------------
function set_shortener(_args) {
cfg.shortener = _args;
}

// --------------------------------------------------------
// get_tweets
//
Expand Down Expand Up @@ -1126,7 +1216,7 @@ function BirdHouse(params) {

return !authorized;
}

// --------------------------------------------------------
// ===================== PUBLIC ===========================
// --------------------------------------------------------
Expand All @@ -1138,6 +1228,7 @@ function BirdHouse(params) {
this.tweet = tweet;
this.short_tweet = short_tweet;
this.shorten_url = shorten_url;
this.set_shortener = set_shortener;

// --------------------------------------------------------
// =================== INITIALIZE =========================
Expand Down