Skip to content

Add an .npmignore file to reduce weight of node_modules dependency #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MrLeebo
Copy link

@MrLeebo MrLeebo commented Oct 23, 2017

jquery-ui is the heaviest dependency in my node_modules folder at 14MB. It appears that this is coming from the demo and externals folders, which I don't think are intended to be part of the distribution.

I took a quick look at the folder structure and put together this .npmignore file, but I would appreciate it if someone more familiar with the project can double check that I didn't leave out anything that actually does need to be in the package.

https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package

Trims down the node_modules file size footprint of jquery-ui (originally 14MB)
@jsf-clabot
Copy link

jsf-clabot commented Oct 23, 2017

CLA assistant check
All committers have signed the CLA.

@dmethvin
Copy link
Member

dmethvin commented Aug 1, 2019

Agreed, but we need more discussion about what is truly needed. Let's consolidate under #1875.

@dmethvin dmethvin closed this Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants