forked from lammps/lammps
-
Notifications
You must be signed in to change notification settings - Fork 1
add compatibility to fix bond/react with a REACTER JSON #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
salamaaya
wants to merge
775
commits into
jrgissing:rate_limit_multi
Choose a base branch
from
salamaaya:fix-bond-react-json
base: rate_limit_multi
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add compatibility to fix bond/react with a REACTER JSON #153
salamaaya
wants to merge
775
commits into
jrgissing:rate_limit_multi
from
salamaaya:fix-bond-react-json
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For clarity and to avoid clashes, we should not define or use any custom variables that have a name starting with CMAKE_
Collected small changes and fixes
a1b85a3 to
ce0b4ca
Compare
…ngulated surfaces
Signed-off-by: Jeremy FERSULA <[email protected]>
…tion Clarify fix align-self doc
…to collected-small-fixes
Support rendering graphics objects from fixes, add a dedicate graphics objects fix, and add and enable transparency handling in dump image
Collected small fixes and updates
9033af1 to
75813f7
Compare
75813f7 to
bec321c
Compare
bec321c to
7dd208d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the
fix bond/reactcommand to work with a REACTER JSON.Note: I updated the
tiny_nylon_jsonfolder to reflect the changes. This included replacing the molecule JSONs and map files with a single REACTER json for eachrxn1_stp*files.Related Issue(s)
Author(s)
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
Implementation Notes
Post Submission Checklist
Further Information, Files, and Links