Skip to content

Conversation

nicoyou
Copy link
Contributor

@nicoyou nicoyou commented Jun 17, 2025

This pull request fixes an issue where the ROOT setting was not being properly read from the configuration.
Due to this, the behavior relying on ROOT did not function as expected in some environments.

Changes made:
Ensured that the ROOT setting is retrieved correctly using getattr with a proper fallback.

Please let me know if any additional changes are needed. Thank you for maintaining this project.

@jrief
Copy link
Owner

jrief commented Jun 17, 2025

Which issue does this solve?
Can I reproduce the problems in that issue?

@nicoyou
Copy link
Contributor Author

nicoyou commented Jun 17, 2025

@jrief
For example, when SASS_PROCESSOR_ENABLED is set to true in django 5.0 (4.2>=),
STORAGES['sass_processor'] = {
'BACKEND': 'django.core.files.storage.FileSystemStorage',
'ROOT': 'static path'
}
Even if you register a setting like this, ROOT will be ignored and the compiled css will be generated directly under the project or in the ROOT of FileSystemStorage.
This update will fix this issue.

@nicoyou
Copy link
Contributor Author

nicoyou commented Jun 20, 2025

@jrief
I don't have permission to merge into the master branch, so if you accept this pull request, please merge it.

@jrief
Copy link
Owner

jrief commented Jun 21, 2025

Again: There is no issue with a description on how to rereduce this bus.

@nicoyou
Copy link
Contributor Author

nicoyou commented Jun 23, 2025

@jrief
I was mistaken, the issue in question is here.
But I couldn't link it.
#181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants