-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autocomplete for location field #733
base: master
Are you sure you want to change the base?
Conversation
I love how it works as a location search, but it makes look like that's all we support. Since it doesn't pick up networks, tags and so on. Plus it doesn't understand the combo + feature. So as a new user I might think it's not even an option. We would have to hope users read the tooltip and don't get discouraged by the auto complete. There must something we can do, maybe add hints inside it? |
I guess you meant a combination of network/tag and a place? That it indeed doesn't work but I think I can make that work too. |
Yes a combo, that's what I use the most of all combos. How about showing a message when no matches are found? That's when it's needed most. Maybe show the contents of the tooltip to make it clear that lack of results doesn't mean it's not going to work |
The tooltip message won't directly help, but I was thinking in that direction, too, now. Will try to write something to show in that case. |
@jimaek check the |
Referencing US states and cities requires jsdelivr/globalping#629, and doesn't work at the moment. Closes #537.
Also fixes displaying error messages for the location field and hides the map in case of errors that are shown below it, as those were easy to miss otherwise.
TODO:
+
to work with networks and tags.