Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user public page #734

Merged
merged 23 commits into from
Mar 19, 2025
Merged

Add user public page #734

merged 23 commits into from
Mar 19, 2025

Conversation

mpourismaiel
Copy link
Contributor

@mpourismaiel mpourismaiel commented Mar 17, 2025

Add user public page, fetching probe data from http://api.globalping.io/v1/probes. Closes #689

TODO:

  • convert design from figma
  • responsive
  • fetch probe data
  • display map with grouped markers
  • user profile section
    • avatar
    • username
    • probe count
    • asn
    • tests/day
    • avg uptime
  • tests' graph section
  • canonical url
  • tests

I haven't yet yet been able to add the canonical url meta. It can be done onrender but setting it after requests are done in the frontend would mean the bots are already done. I think the only proper way to add it would be fetching probes data server side. @MartinKolarik Shall I add the data.username instead of userProbes.tags -> username tag for now?

Sorry, something went wrong.

@MartinKolarik
Copy link
Member

It can be done onrender but setting it after requests are done in the frontend would mean the bots are already done.

This should actually be sufficient for Google, but we already kinda have that data on the server and need to update the sitemap to include those pages anyway, so let's do both. You can update this to refresh every minute instead of hour (and store the username list there), and then use it for the canonical URL and 404 for invalid values.

You can also update the sitemap handling. Currently, sitemap at index 0 is for the main pages, and from 1, we list the network-tools pages; you can change it so that 1 is for user pages (those will always fit in one file), and network pages start at 2.

Copy link
Member

@MartinKolarik MartinKolarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few improvements to do, but looks good for a start.

Copy link
Member

@MartinKolarik MartinKolarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can update this to refresh every minute instead of hour (and store the username list there), and then use it for the canonical URL and 404 for invalid values.
You can also update the sitemap handling. Currently, sitemap at index 0 is for the main pages, and from 1, we list the network-tools pages; you can change it so that 1 is for user pages (those will always fit in one file), and network pages start at 2.

Not sure if you're still working on this one or not but let's do it as well and then I think we're good here.

@MartinKolarik MartinKolarik merged commit d49b5e4 into jsdelivr:master Mar 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GP: Public user dedicated pages
2 participants