Support single-arch mac layouts in DMG postprocess#75
Merged
jsgrrchg merged 3 commits intoMay 11, 2026
Conversation
electron-builder writes the .app under mac-arm64/ or mac-x64/ when invoked with --arch arm64|x64, but findPackagedApp only knew about mac-universal/ and mac/. A local arm64 build (or any non-universal mac release) would fail postprocess with "Could not find packaged NeverWrite.app".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/desktop/scripts/postprocess-macos-dmg.mjs'sfindPackagedApponly looks formac-universal/NeverWrite.appandmac/NeverWrite.app. Whenbuild-electron-release.mjsis invoked with--arch arm64(or--arch x64), electron-builder writes the bundle undermac-arm64/ormac-x64/instead, and the postprocess step fails with:That makes a local single-arch macOS release impossible without bypassing the hardened DMG rebuild and codesign-verify step. Adding the two missing candidates keeps the universal layout working unchanged and unblocks single-arch builds.
Test plan
node apps/desktop/scripts/build-electron-release.mjs --platform mac --arch arm64 --unsignedruns through postprocess without error--arch universalbuild still findsmac-universal/NeverWrite.app(candidate retained)