Show .html and .htm files in default file tree#76
Merged
Conversation
In notes_only mode the sidebar previously surfaced only .md notes and .pdf files. HTML files come back from the vault classifier as text-like, open-in-app entries, but were filtered out unless the user enabled the global "all files" toggle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the default
notes_onlymode the sidebar surfaced only.mdnotes and.pdffiles..htmland.htmfiles come back from the vault classifier as text-like, openable entries (kind"file", mimetext/html), but they were filtered out unless the user enabled the global "all files" toggle in settings.The patch extends the default filter to also surface
.html/.htmby extension. The"all_files"toggle is unchanged.The matching is on
entry.extension, which the Rust side atcrates/vault/src/vault.rs:744already lowercases, so casing is handled.Click-through works without further wiring: the vault classifier maps
html/htmtotext/html, whichis_text_like_mime_typeaccepts, so the entry already comes back withopen_in_app: trueand the existing text/code viewer renders the source.Test plan
.htmland.htmfiles alongside notes and PDFsapps/desktopvitest run src/features/vault/FileTree.test.tsx(47 tests) passes