Skip to content

Commit

Permalink
Fixup 6ac62fe
Browse files Browse the repository at this point in the history
Drop unused catkin_python_setup().
The call and setup.py are only required when defining python modules,
but jsk_recognition_msgs does not expose a python package (aside from
the autogenerated package for the messages).

This got noticed because Debian's python setuptools complains about
missing package list in setup.py:

---
error: Multiple top-level packages discovered in a flat-layout: ['srv', 'msg', 'debian', 'action', 'sample'].

To avoid accidental inclusion of unwanted files or directories,
setuptools will not proceed with this build.

If you are trying to create a single distribution with multiple packages
on purpose, you should not rely on automatic discovery.
Instead, consider the following options:

1. set up custom discovery (`find` directive with `include` or `exclude`)
2. use a `src-layout`
3. explicitly set `py_modules` or `packages` with a list of names

To find more information, look for "package discovery" on setuptools docs.
CMake Error at catkin_generated/safe_execute_install.cmake:4 (message):

  execute_process(/<<BUILDDIR>>package/.obj-x86_64-linux-gnu/catkin_generated/python_distutils_install.sh)
  returned error code
Call Stack (most recent call first):
  cmake_install.cmake:46 (include)
---
  • Loading branch information
v4hn committed Nov 11, 2024
1 parent a3283f8 commit 93a9871
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
3 changes: 0 additions & 3 deletions jsk_recognition_msgs/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ cmake_minimum_required(VERSION 2.8.3)
project(jsk_recognition_msgs)
find_package(catkin REQUIRED
std_msgs sensor_msgs geometry_msgs message_generation pcl_msgs jsk_footstep_msgs)
if(NOT $ENV{ROS_DISTRO} STREQUAL "indigo") # on noetic it needs catkin_install_python to support Python3 and it does not work on indigo for some reason...
catkin_python_setup()
endif()
add_message_files(
FILES
Accuracy.msg
Expand Down
17 changes: 0 additions & 17 deletions jsk_recognition_msgs/setup.py

This file was deleted.

0 comments on commit 93a9871

Please sign in to comment.