Port to use kotlinx-io #159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on code. Add wasmJs target.
|
The build is failing when trying to upload the coverage report to Codecov. It looks like a missing token. Do you have the secret CODECOV_TOKEN set? |
|
waiting for this to merge 👀 |
|
@jsoizo Hi. Are there any news on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented #157, #133. Converted all java io usage to kotlinx-io and moved all code to commonMain, except tests that required reading files (additional tests may still be able to be moved to commonTest). This should make it easier to also support #151 and #15 in the future by adding appropriate build targets.