fix: Update Go Back button URL on implementers page #1517
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1517 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 396 396
Branches 106 106
=========================================
Hits 396 396 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Priyanshuthapliyal2005 The issue hasn't been approved yet and is not assigned to you. Please check the contribution guidelines and please close the PR to make it easier for the maintainers. |
Thank you for your feedback. I've reviewed the contribution guidelines and couldn't find any explicit requirement about needing issue approval before submitting a PR. If there's a specific guideline I missed, please let me know and I'll be happy to adjust accordingly. |
|
@Priyanshuthapliyal2005, it's mentioned in the PR format and the guidelines that an issue can only be worked on after being released from triage. I made this mistake myself, so I thought it would be helpful to let you know, as a lot of the maintainers time is spent closing PRs for issues that are still in triage. |
Thank you for the heads up! I’d appreciate it if you could share a screenshot where this is mentioned in the guidelines. Once confirmed, I will close this PR. 😊 |
|
Congratulations, @Priyanshuthapliyal2005 for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema! |
What kind of change does this PR introduce?
Fixed the "Go Back" button navigation on the implementers page by updating the URL from
/guidesto/learn/guides.Changes
prevURLprop inpages/implementers/index.page.tsxto point to the correct guides page locationTesting
/learn/guidesIssue Number:
Screenshots/videos:
gobackworking.mp4
If relevant, did you update the documentation?
Summary
The "Go Back" button on the Implementers page was navigating to an incorrect URL (
/guides), resulting in a 404 error. This PR fixes the navigation by updating the URL to the correct path (/learn/guides).This change ensures users can properly navigate back from the Implementers page to the Guides section, improving the overall navigation experience of the documentation.
Does this PR introduce a breaking change?
no