Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] : Docs Navigation Bar in the mobile dimensions #1518

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Yashwanth1906
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix for mobile Docs navigation bar scroll

Issue Number:

Screenshots/videos:

After:

Screen.Recording.2025-03-14.191538.mp4

If relevant, did you update the documentation?
N/A.

Summary

  1. Fixed the mobile navigation scroll behavior by:
    • Adding proper scroll lock when the mobile menu is open
    • Preventing background content scroll while nav is open
    • Maintaining scroll position when closing the menu

Does this PR introduce a breaking change?
No

@Yashwanth1906 Yashwanth1906 requested a review from a team as a code owner March 14, 2025 13:49
Copy link

github-actions bot commented Mar 14, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview cd4aa35

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (219521e) to head (cd4aa35).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1518   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Yashwanth1906
Copy link
Contributor Author

@DhairyaMajmudar Review this PR.

@DhairyaMajmudar
Copy link
Member

@Yashwanth1906 fix this

image

@Yashwanth1906
Copy link
Contributor Author

@Yashwanth1906 fix this

image

@DhairyaMajmudar Fixed this issue .

@Yashwanth1906
Copy link
Contributor Author

@benjagm @DhairyaMajmudar Is there anything i need to change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants