-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Add tour of JSON Schema section on homepage (#1502) #1532
Enhancement: Add tour of JSON Schema section on homepage (#1502) #1532
Conversation
Hi @KajalMishra-29! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference, kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
Thanks a lot @KajalMishra-29, this is a great idea, but as of now we prefer to keep the onboarding experience and the codebase as simple as possible. |
Is there a PR where we discussed this? |
Hi @KajalMishra-29! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
This enhancement was based on issue #1502, which suggests adding a guided tour to the homepage. |
Thank you for the feedback! I understand the concern about keeping the onboarding experience simple. Would you be open to a more minimal version of the tour, focusing only on the most essential elements (e.g., Docs, Specification, and Community)? I can modify the implementation accordingly. |
Hi @KajalMishra-29! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference, kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
Let's continue the discussion on the issue first. |
Hi @KajalMishra-29! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference, kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
Closing this PR as the issue is still on triage. |
This PR adds a guided tour to the homepage using
react-joyride
, helping new users explore key components of the homepage. The tour highlights important elements in the navbar and main sections, providing descriptions for each.Kind of Change: Feature enhancement
issue number
closes : #1502
Changes Made
Created a new component
TourGuide.tsx
that:useState
anduseEffect
to manage the tour lifecycleStart Tour
button (bottom-right) to trigger the tourIntegrated
TourGuide.tsx
inindex.page.tsx
so the tour is available on the homepage.How to Test
description for element's can be changed as required.
Let me know if any refinements are needed! 🚀