Support for new TokenType type alongside with compatibility for older doctrine/orm versions #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der doctrine versions
|
@jsor Any updates for this? |
|
@jsor same question - any news? Is critical for me :( |
|
@imancos-xsoft I ended up working with my fork. I can make it public on packagist.org if you want so you can use it |
|
@MathisBurger Hey, sorry for being unresponsive for so long. I've added you as an collaborator to this repo. So, feel free to merge and release. |
|
@jsor @MathisBurger It would be better to merge this PR #61 which includes these changes. |
|
@jsor No problem. @maxhelias sounds good to me. Should I create then create a new release just after merging #61 ? |
Sure, go ahead 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have introduced an alias class that dynamically selects either Doctrine\ORM\Query\Lexer or Doctrine\ORM\Query\TokenType for token constants. This approach allows compatibility with a wide range of doctrine/orm versions while using the same version of jsor. As a result, we support both newer and older versions of Doctrine seamlessly.
I also had to edit psalm and test creation in order to support latest versions of doctrine