feat(proto): reveal oracle request for simulation#1419
Open
feat(proto): reveal oracle request for simulation#1419
Conversation
575cc3e to
e39d7e5
Compare
Codecov Report❌ Patch coverage is
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
e39d7e5 to
337f494
Compare
337f494 to
a41b7c6
Compare
a41b7c6 to
31d9895
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is the final step enable oracle simulation in the kernel.
Closes: JSTZ-1048
Description
Moved
Revealertrait tojstz_core: This makes the trait available for both simulation and non-simulation modes.Refactored
process_and_dispatch_request: Split the implementation into:process_and_dispatch_request_impl<Rv: Revealer>- A generic implementation that accepts any type implementingRevealerprocess_and_dispatch_requestthat call the impl with:HostRevealerfor simulation mode (uses reveal channel for oracle requests)()stub type for non-simulation mode (oracle requests use protocol context instead )Added simulation oracle dispatch: Implemented
dispatch_oracle::<Rv>for simulation mode that encodes HTTP requests and sends them via the reveal channel usingsimulation::send_request.Added error conversion: Implemented
From<jstz_core::Error>forResponseto handle reveal channel error.Cleaned up the imports of
fetch_handler.rs: grouped the imports by cratesUpdated Makefile to run proto test with the simulation feature
Manually testing the PR