Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider min max Value #68

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

MykhailoDav
Copy link
Contributor

@MykhailoDav MykhailoDav commented Dec 10, 2024

Hi!
First of all, a huge thank you to @jsuarezruiz and the other contributors for the great work, your controls are really great!

When I was using your Slider, I noticed that its values went beyond the Minimum and Maximum, and @BinaryAssault encountered the same thing in Slider Issues #52

Screenshot 2024-12-10 at 18 14 50
Screenshot 2024-12-10 at 18 14 57
(current behavior when min=0, max=10)

In this PR, I added a Label for the Slider Value, and a math function to limit its value

Fixes #52

Feel free to ask questions.

I hope for a quick review of my contribution to your project, I need it for my project.
Thank you very much!

@jsuarezruiz jsuarezruiz self-requested a review February 4, 2025 16:17
@jsuarezruiz
Copy link
Owner

Thanks for the PR, will review it soon!

@jsuarezruiz jsuarezruiz merged commit e79e5c1 into jsuarezruiz:main Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider Issues
2 participants