Adding a PP class for exposing pretty printers...

[ranjitjhala]

Hey guys, I added a PP class to expose the pretty printers. Would be much obliged if you could quickly accept this request, as I want to put an assignment out that needs it.

(Somehow cabal is insisting on downloading the latest copy from hackage and not my local one...)

Many thanks!

[jpolitz]

Do you get these? I'm vaguely afraid I'll mess up Haskell stuff so
I'd rather you do this merge.

---------- Forwarded message ----------
From: Ranjit Jhala [email protected]
Date: Thu, May 23, 2013 at 11:12 AM
Subject: [language-ecmascript] Adding a PP class for exposing pretty
printers... (#8)
To: jswebtools/language-ecmascript [email protected]

Hey guys, I added a PP class to expose the pretty printers. Would be
much obliged if you could quickly accept this request, as I want to
put an assignment out that needs it.

(Somehow cabal is insisting on downloading the latest copy from
hackage and not my local one...)

Many thanks!

---

You can merge this Pull Request by running

git pull https://github.com/UCSD-PL/language-ecmascript pp

Or view, comment on, or merge it at:

#8

Commit Summary

what, where is PP

File Changes

M src/Language/ECMAScript3/PrettyPrint.hs (39)

Patch Links:

https://github.com/jswebtools/language-ecmascript/pull/8.patch
https://github.com/jswebtools/language-ecmascript/pull/8.diff

[jpolitz]

Meant to CC Arjun specifically.

On Thu, May 23, 2013 at 11:39 AM, Joe Gibbs Politz [email protected] wrote:

Do you get these? I'm vaguely afraid I'll mess up Haskell stuff so
I'd rather you do this merge.

---------- Forwarded message ----------
From: Ranjit Jhala [email protected]
Date: Thu, May 23, 2013 at 11:12 AM
Subject: [language-ecmascript] Adding a PP class for exposing pretty
printers... (#8)
To: jswebtools/language-ecmascript [email protected]

Hey guys, I added a PP class to expose the pretty printers. Would be
much obliged if you could quickly accept this request, as I want to
put an assignment out that needs it.

(Somehow cabal is insisting on downloading the latest copy from
hackage and not my local one...)

Many thanks!

---

You can merge this Pull Request by running

git pull https://github.com/UCSD-PL/language-ecmascript pp

Or view, comment on, or merge it at:

#8

Commit Summary

what, where is PP

File Changes

M src/Language/ECMAScript3/PrettyPrint.hs (39)

Patch Links:

https://github.com/jswebtools/language-ecmascript/pull/8.patch
https://github.com/jswebtools/language-ecmascript/pull/8.diff

[shriram]

I got it...

[achudnov]

Hi Ranjit,I'm the current package maintainer. Thanks for the patch. I'm at a conference and I don't have my dev system with me. I'm back on Monday and will look at the patch then.

In the mean time, you can increase the version number locally and increase the minimum version of language-ecmascript you require in the cabal file of the package that uses it.

/Andrey

----- Reply message -----
From: "Ranjit Jhala" [email protected]
To: "jswebtools/language-ecmascript" [email protected]
Subject: [language-ecmascript] Adding a PP class for exposing pretty printers... (#8)
Date: Thu, May 23, 2013 8:12 AM

Hey guys, I added a PP class to expose the pretty printers. Would be much obliged if you could quickly accept this request, as I want to put an assignment out that needs it.

(Somehow cabal is insisting on downloading the latest copy from hackage and not my local one...)

Many thanks!

You can merge this Pull Request by running
git pull https://github.com/UCSD-PL/language-ecmascript pp
Or view, comment on, or merge it at:
#8

Commit Summary

what, where is PP

File Changes

M
src/Language/ECMAScript3/PrettyPrint.hs
(39)

Patch Links:

https://github.com/jswebtools/language-ecmascript/pull/8.patch
https://github.com/jswebtools/language-ecmascript/pull/8.diff

[ranjitjhala]

Yes no worries figured out an easy way around the issue...

On May 23, 2013, at 9:28 AM, Andrey Chudnov [email protected] wrote:

Hi Ranjit,I'm the current package maintainer. Thanks for the patch. I'm at a conference and I don't have my dev system with me. I'm back on Monday and will look at the patch then.

In the mean time, you can increase the version number locally and increase the minimum version of language-ecmascript you require in the cabal file of the package that uses it.

/Andrey

----- Reply message -----
From: "Ranjit Jhala" [email protected]
To: "jswebtools/language-ecmascript" [email protected]
Subject: [language-ecmascript] Adding a PP class for exposing pretty printers... (#8)
Date: Thu, May 23, 2013 8:12 AM

Hey guys, I added a PP class to expose the pretty printers. Would be much obliged if you could quickly accept this request, as I want to put an assignment out that needs it.

(Somehow cabal is insisting on downloading the latest copy from hackage and not my local one...)

Many thanks!

You can merge this Pull Request by running
git pull https://github.com/UCSD-PL/language-ecmascript pp
Or view, comment on, or merge it at:
#8

Commit Summary

what, where is PP

File Changes

M
src/Language/ECMAScript3/PrettyPrint.hs
(39)

Patch Links:

https://github.com/jswebtools/language-ecmascript/pull/8.patch
https://github.com/jswebtools/language-ecmascript/pull/8.diff
—
Reply to this email directly or view it on GitHub.

[achudnov]

Just wanted to thank Ranjit again for submitting the pull request and Arjun for merging it and deploying it on such short notice. In future, please, submit pull requests against the "dev" branch.
This is the change that is simple but profoundly useful and it's a "facepalm" moment that it wasn't present already :)
However, I'm vaguely unhappy with the names for the "PP" typeclass and it's method, as well as lack of documentation. I'll be looking to fix that in the coming week, adding the appropriate deprecates if necessary.

[ranjitjhala]

Thanks all!

On May 27, 2013, at 9:53 AM, Andrey Chudnov [email protected] wrote:

Just wanted to thank Ranjit again for submitting the pull request and Arjun for merging it and deploying it on such short notice. In future, please, submit pull requests against the "dev" branch.
This is the change that is simple but profoundly useful and it's a "facepalm" moment that it wasn't present already :)
However, I'm vaguely unhappy with the names for the "PP" typeclass and it's method, as well as lack of documentation. I'll be looking to fix that in the coming week, adding the appropriate deprecates if necessary.

—
Reply to this email directly or view it on GitHub.